From: Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
To: frank zago <fzago-klaOcWyJdxkshyMvu7JE4pqQE7yCjDx5@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [patch 1/8] Ammasso - ib_post_send fix
Date: Wed, 02 Dec 2009 09:34:52 -0800 [thread overview]
Message-ID: <adaws15uvnn.fsf@roland-alpha.cisco.com> (raw)
In-Reply-To: <4B0C19A1.1050008-klaOcWyJdxkshyMvu7JE4pqQE7yCjDx5@public.gmane.org> (frank zago's message of "Tue, 24 Nov 2009 11:36:33 -0600")
These patches seem to be mangled and won't apply... the main problem
seems to be that your MUA is setting Content-Type to format=flowed,
which destroys the whitespace. Please fix up your mail setup and resend.
(get-send-email will almost always work if nothing else will)
While you're fixing that up, please also fix the subject lines -- ef for
this patch the header shouldn't be "Ammasso -" but rather
"RDMA/amso1100:" as the other entries in the log for that driver use.
And also after your signed-off-by line, put a line with "---" on it so
git drops everything afterwards from the changelog, and include a
diffstat there to make it clear what the patch touches.
(These comments apply to the whole series, but you can drop the nes
patches since Chien picked those up)
Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-12-02 17:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20091124043323.927819053@systemfabricworks.com>
[not found] ` <20091124043323.927819053-klaOcWyJdxkshyMvu7JE4pqQE7yCjDx5@public.gmane.org>
2009-11-24 17:36 ` [patch 1/8] Ammasso - ib_post_send fix frank zago
[not found] ` <4B0C19A1.1050008-klaOcWyJdxkshyMvu7JE4pqQE7yCjDx5@public.gmane.org>
2009-12-02 17:34 ` Roland Dreier [this message]
2009-11-24 17:36 ` [patch 2/8] ehca - ib_post_send fixes Always set ib_post_send()s bad_wr. Do not report success if an error occurred frank zago
2009-11-24 17:36 ` [patch 3/8] cxgb3 - ib_post_send fixes frank zago
2009-11-24 17:36 ` [patch 4/8] cxgb3 - ib_post_recv fixes frank zago
2009-11-24 17:36 ` [patch 5/8] ehca - ib_post_recv fixes Always set ib_post_recv()s bad_wr frank zago
[not found] ` <4B0C19AE.6030006-klaOcWyJdxkshyMvu7JE4pqQE7yCjDx5@public.gmane.org>
2009-11-24 23:06 ` Alexander Schmidt
2009-11-24 23:28 ` frank zago
2009-11-24 17:36 ` [patch 7/8] NES - ib_post_send fixes frank zago
[not found] ` <4B0C19B1.8030304-klaOcWyJdxkshyMvu7JE4pqQE7yCjDx5@public.gmane.org>
2009-11-24 20:00 ` Tung, Chien Tin
2009-11-24 17:36 ` [patch 6/8] ammasso - ib_post_recv fix frank zago
2009-11-24 17:36 ` [patch 8/8] NES - ib_post_recv fixes frank zago
[not found] ` <4B0C19B8.8010807-klaOcWyJdxkshyMvu7JE4pqQE7yCjDx5@public.gmane.org>
2009-11-24 20:00 ` Tung, Chien Tin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adaws15uvnn.fsf@roland-alpha.cisco.com \
--to=rdreier-fyb4gu1cfyuavxtiumwx3w@public.gmane.org \
--cc=fzago-klaOcWyJdxkshyMvu7JE4pqQE7yCjDx5@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox