From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roland Dreier Subject: Re: [PATCH] IB/core: export struct ib_port Date: Wed, 11 Nov 2009 15:38:51 -0800 Message-ID: References: <1257966478.992.300.camel@chromite.mv.qlogic.com> <1257970050.992.317.camel@chromite.mv.qlogic.com> <1257981770.992.336.camel@chromite.mv.qlogic.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: <1257981770.992.336.camel-/vjeY7uYZjrPXfVEPVhPGq6RkeBMCJyt@public.gmane.org> (Ralph Campbell's message of "Wed, 11 Nov 2009 15:22:50 -0800") Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ralph Campbell Cc: Dave Olson , linux-rdma List-Id: linux-rdma@vger.kernel.org > While this is true for SLtoVL, we create other files which are > device specific under the port directory too. > It seems like we might need to introduce a callback into the driver to > create the port specific sysfs files. Umm, you could have said there were other things initially! Anyway, rather than a callback, I guess we could just add a place to attach a set of port attributes to the structure that gets passed into ib_register_device() maybe? And maybe we could clean up the existing code that does device_create_file() to use a list of device attributes also... - R. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html