Re: [PATCH] IB/core: export struct ib_port

Dave Olson
2009-11-12T05:38:43Z

On Wed, 11 Nov 2009, Roland Dreier wrote:

|
| > While this is true for SLtoVL, we create other files which are
| > device specific under the port directory too.
| > It seems like we might need to introduce a callback into the driver to
| > create the port specific sysfs files.
|
| Umm, you could have said there were other things initially!

Those have been there "forever" in qib without requiring the change
in the core sysfs code. It's only sysfs group entries that require
the patch to expose ib_port.

| Anyway, rather than a callback, I guess we could just add a place to
| attach a set of port attributes to the structure that gets passed into
| ib_register_device() maybe?

Seems like major overkill to have callbacks, when all we need is to
get the structure that "owns" (is the parent kobject of) the directory.

| And maybe we could clean up the existing code that does
| device_create_file() to use a list of device attributes also...

Seems to be a rather different issue, to me.

Dave Olson
dave.olson-h88ZbnxC6KDQT0dZR+AlfA@public.gmane.org