Re: [PATCHv10 03/12] ib_core: IBoE UD packet packing support

[Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>]

 > +	if (lrh_present) {
 > +		header->lrh.link_version     = 0;
 > +		header->lrh.link_next_header =
 > +			grh_present ? IB_LNH_IBA_GLOBAL : IB_LNH_IBA_LOCAL;
 > +		packet_length = IB_LRH_BYTES;
 > +	}
 > +
 > +	if (eth_present)
 > +		packet_length += IB_ETH_BYTES;

How does this code in ib_ud_header_init() work if lrh_present == 0 and
eth_present == 1?  It seems packet_length is never initialized in that
case, or am I missing something?

Anyway I changed the patch in my tree to do

	packet_length = IB_ETH_BYTES

if eth_present is set.

I'm assuming lrh_present and eth_present are exclusive; in fact it might
be a better interface to ib_ud_header_init() if we passed in a link
layer type instead of requiring the caller to do it... that would save
from everyone having to do

+	ib_ud_header_init(send_size, !is_eth, is_eth, is_grh, 0, &sqp->ud_header);

as ends up later in the patch series.

This could be a future cleanup if we care.

 - R.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html