From: Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
To: Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Al Viro <viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
Subject: Re: linux-next: manual merge of the infiniband tree with the vfs tree
Date: Fri, 26 Feb 2010 14:02:55 -0800 [thread overview]
Message-ID: <adazl2vvenk.fsf@roland-alpha.cisco.com> (raw)
In-Reply-To: <20100226130518.94c5a5f8.sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org> (Stephen Rothwell's message of "Fri, 26 Feb 2010 13:05:18 +1100")
> Today's linux-next merge of the infiniband tree got a conflict in
> drivers/infiniband/core/uverbs_main.c between commit
> ce916e2b935f8b3402da1457ff23b9f9f786c09b ("switch infiniband uverbs to
> anon_inodes") from the vfs tree and commit
> 4169c4a9735d6434c9e39fa81ae5517e3afd4cd8 ("IB/uverbs: Use anon_inodes
> instead of private infinibandeventfs") from the infiniband tree.
>
> These two commits purport to do something similar. Someone should look
> at them both and decide which one is right. For now I have used the
> version from the vfs tree - with the addition of the part from the
> infiniband tree version that selects ANON_INODES in the Kconfig file.
Huh, I didn't see that vfs commit and as far as I can tell it was never
posted anywhere. Which I guess is why we have linux-next :)
Anyway, both commits look essentially equivalent -- Al's moves the fd
allocation to callers, which is OK with me (a bit of duplicated code but
maybe a bit better layering of functions). I would like to see the
Kconfig part go in as part of the patch, although I guess it's not such
a terrible bit of breakage to fix up a bit after the fact. (Not a real
bisection killer)
Al, let me know what you want to do -- I can pick up your patch or drop
the patch from my tree, either way is fine.
- R.
--
Roland Dreier <rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2010-02-26 22:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-26 2:05 linux-next: manual merge of the infiniband tree with the vfs tree Stephen Rothwell
[not found] ` <20100226130518.94c5a5f8.sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2010-02-26 22:02 ` Roland Dreier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adazl2vvenk.fsf@roland-alpha.cisco.com \
--to=rdreier-fyb4gu1cfyuavxtiumwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org \
--cc=viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox