From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8265C328B62 for ; Mon, 4 May 2026 20:56:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777928166; cv=none; b=sfAKnhQNMR4dlDLv2B44oE8UmZpy58x/F9bxJ0c4UZS2t20tCy94u+J7h+vVgwwvpEKz1TtvOwoYiGVAIxTrGw7e5k9O++eaXf4oazcJsLypDRSrvZd8nqD9+VBTmEyhY6ASwpZ25goP4Qko0RIw46HkbS8/bwOxiL8sgjrLJoY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777928166; c=relaxed/simple; bh=6b0uhsWOUueBJikO+3RxwH3ywe4vOaHqBvUoJ1iBG10=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jGTONmj8JHrF1GtfYeukw6WbwNQ1rGbssmF8DOeyrKfCs164oCBQKlDDwygDW3C4zC8Enysj65jWZe6EenkqVvFcP4LlQfTAJ4pFzd0hjwMek6uAy4rstYhKOAf8eQcFpVTWG+WiJnl6z/ldE/vnr5rWGycDP6fLcS9s8HWxdbk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=e8I0RQIW; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="e8I0RQIW" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2ad9a9be502so25254785ad.0 for ; Mon, 04 May 2026 13:56:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1777928163; x=1778532963; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=uAEnOAPj5fUgAFUXnOyePT2fFfy+RA0tHhuCu8Z9sp0=; b=e8I0RQIWCDwpXPl0zwFKbvPBkUL4uuvj/YzwuEeRwSD1/RzGp6Ds2YnVgBznjkvqXV NgS/RiwiwRaZmkSJhvDrZ9wpsz61E3uI8uu6TFxaC27O8HUEWFMldbI27OjpAyJufE61 sHtQkwdVOz0ieMakt03HswwGvApprhDBUHTxMfhqkrpN14E5ya1ycHM4DvInNz+MaxDg PoB18jN7QCmgr4sDXizPHaLnc42NHLHwUJ955HcezumMxiFHnmwh+bAoaSovB9J9/PVl PzxgB//5/z4EwNoxQACSPFB2UWcw6K61C78Vx3ebh4F6o0IS9IJGnPFsZhrIQ7ap83RC SQDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777928163; x=1778532963; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uAEnOAPj5fUgAFUXnOyePT2fFfy+RA0tHhuCu8Z9sp0=; b=o/7DqmBbugl03mwa5AEzdEbtVPmRo8d+6nAzcc0wvWi52wQeGMDS4M7lYy7T+/Zby6 DYlVbDSHyHHtME4q/KRPeYSdPMSTZ8CgP8Z3wd2Gcel0Cv4B9FNk22Og7wEyTri+8ye6 hweocAFphY+f28llYkUKDzr75bTHIGvqEyc0/WPPks4SUtt3eVwa5HV6+ybRzQ0FcgYv mnSdapuMhnw/WR4PaYoDqP9HYwFnMMb0viwvbk0+J9G9DNzZNMv8tKWsFRT90zhg6Grr ZAZiVRX0Xc3/mWLTorm/qQ+8Zs2zTM7wwlhoCin01gaooYUj49pIL9WUXHyO+QHkCD0p cv2Q== X-Forwarded-Encrypted: i=1; AFNElJ82P2NYiX0NYYw8Q9QHn068eH0k3fOfsuAH8AFaOgfJiFVeTLXSheasqrXL6G8OcxHqOCbhMkNVNP6w@vger.kernel.org X-Gm-Message-State: AOJu0YynYK9kAQPp8+bXw+Zah73hSjWcWxbTveuGPwzHsaMxOuoaL9i5 ykRJeRLp4ni+tenhJA3jXGtePTt4DimjkV4WGCOXPh1qaRzytJKuj0kIMNFLom/0OA== X-Gm-Gg: AeBDietIAELo8wfdXg9zheccf//OYpIzfTxMICSSaFJYRxlZQO0cJUwCXPb7dsDl/v8 MrKb9P1pS8MkU1VS/u84bi7QuGyVwmDkDIFeCBB0aAINV4n4hD+z+lobXjrRsM0eXkazKiGFK+k nnQmrby7jkw9HE+GXrES/+pBBbXkthEaQARf/HYKXyvgqwc88+5tieO7LcFnVrTXAGHgRGMZCdn CJRxF/KDOhLz5HuBW5cpWKHAJcGt17HFYAM6pMJv1TO0s8GlhdTnC9paiIzyN6Fui6Qw3V04OXw FnOYqQtzwuzdS16oUSmB5P3a3fpOJ51/XiCSUsKSYup+Fa0siarNshx8exMpaLyueMZ4qEiMOtD I3zgHEq5+S+731tt1B+Gb0ytKqlXKINZ2EjGsyroQ7J2o9NTqlq94+e+eMpmFxUFop9pOs7+QPe Lz6JJk3+576q5u8HT7GPSFyJPG6umPPLsfpTb1h1Vb6Z8nV9sdVxOjVY94QMnjRQs9FjiuO7Bf6 5K0bQ== X-Received: by 2002:a17:902:f64a:b0:2b4:5a2e:98d9 with SMTP id d9443c01a7336-2ba53896e5bmr1405745ad.37.1777928162684; Mon, 04 May 2026 13:56:02 -0700 (PDT) Received: from google.com (76.9.127.34.bc.googleusercontent.com. [34.127.9.76]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b9caa7e7besm116816715ad.12.2026.05.04.13.56.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 13:56:02 -0700 (PDT) Date: Mon, 4 May 2026 20:55:58 +0000 From: David Matlack To: Jason Gunthorpe Cc: Alex Williamson , kvm@vger.kernel.org, Leon Romanovsky , linux-kselftest@vger.kernel.org, linux-rdma@vger.kernel.org, Mark Bloch , netdev@vger.kernel.org, Saeed Mahameed , Shuah Khan , Tariq Toukan , patches@lists.linux.dev Subject: Re: [PATCH 07/11] vfio: selftests: Allow drivers to specify required region size Message-ID: References: <0-v1-dc5fa250ca1d+3213-mlx5st_jgg@nvidia.com> <7-v1-dc5fa250ca1d+3213-mlx5st_jgg@nvidia.com> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7-v1-dc5fa250ca1d+3213-mlx5st_jgg@nvidia.com> On 2026-04-30 09:08 PM, Jason Gunthorpe wrote: > Add a region_size field to struct vfio_pci_driver_ops so drivers can > declare how much DMA-mapped region they need. The mlx5 driver will > need ~18MB for firmware pages. Existing drivers leave region_size as > 0 and get the current default of SZ_2M. I would like to get rid of the magic SZ_2M to make it easier for other tests to use the driver framework. Can you make this commit update all the drivers to set region_size? They can all use the same approach: struct vfio_pci_driver_ops foo_driver = { ... .region_size = roundup_pow_of_two(sizeof(struct foo)), ... };