From: "Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Chengchang Tang <tangchengchang@huawei.com>,
Junxian Huang <huangjunxian6@hisilicon.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Markus Schneider-Pargmann <msp@baylibre.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RDMS/hns: Use named initializer for pci_device_id array
Date: Wed, 13 May 2026 22:14:11 +0200 [thread overview]
Message-ID: <agTbe0HM9hb1Irek@monoceros> (raw)
In-Reply-To: <177869828038.2371282.17935591061454741759.b4-ty@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 773 bytes --]
On Wed, May 13, 2026 at 02:51:20PM -0400, Leon Romanovsky wrote:
>
> On Thu, 07 May 2026 09:54:37 +0200, Uwe Kleine-König (The Capable Hub) wrote:
> > While being more verbose using a named initializer yields easier to
> > understand code and doesn't rely on the two hidden zeros in the
> > PCI_VDEVICE macro.
> >
> > While at it, also drop the explicit zero in the terminating entry.
> >
> > This doesn't introduce any changes to the compiled result of the array,
> > which was confirmed on x86 and arm64.
> >
> > [...]
>
> Applied, thanks!
>
> [1/1] RDMS/hns: Use named initializer for pci_device_id array
> https://git.kernel.org/rdma/rdma/c/9dd3e17173bfb8
Thanks for picking the patch up and also for the typo fix!
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2026-05-13 20:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-07 7:54 [PATCH] RDMS/hns: Use named initializer for pci_device_id array Uwe Kleine-König (The Capable Hub)
2026-05-11 1:53 ` Junxian Huang
2026-05-13 18:51 ` Leon Romanovsky
2026-05-13 20:14 ` Uwe Kleine-König (The Capable Hub) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agTbe0HM9hb1Irek@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=huangjunxian6@hisilicon.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=msp@baylibre.com \
--cc=tangchengchang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox