Re: [PATCH 5/6] RDMA/core: Move ucaps into ib_uverbs_support.ko

[Jiri Pirko <jiri@resnulli.us>]

Wed, May 13, 2026 at 07:33:27PM +0200, jgg@nvidia.com wrote:
>mlx5 uses these move them into the support module from ib_uverbs.ko.
>
>Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>

This breaks the build:

  drivers/infiniband/core/ucaps.c:59:3: error: non-void function 'ib_cleanup_ucaps' should return a value [-Wreturn-mismatch]
     59 |                 return;
        |                 ^

The signature was changed from void to int and a "return 0;" was added
at the tail, but the early return inside the !ucaps_class_is_registered
branch was missed:

	static int ib_cleanup_ucaps(void)
	{
		mutex_lock(&ucaps_mutex);
		if (!ucaps_class_is_registered) {
			mutex_unlock(&ucaps_mutex);
			return;             /* <-- needs to be "return 0;" */
		}

[..]


>@@ -265,3 +266,6 @@ int ib_get_ucaps(int *fds, int fd_count, uint64_t *idx_mask)
> 	mutex_unlock(&ucaps_mutex);
> 	return ret;
> }
>+EXPORT_SYMBOL_NS_GPL(ib_get_ucaps, "rdma_core");
>+
>+module_init(ib_cleanup_ucaps);

Shouldn't this be module_exit()?

[..]