From: Jiri Pirko <jiri@resnulli.us>
To: Jacob Moroni <jmoroni@google.com>
Cc: linux-rdma@vger.kernel.org, jgg@ziepe.ca, leon@kernel.org,
mrgolin@amazon.com, gal.pressman@linux.dev, sleybo@amazon.com,
parav@nvidia.com, mbloch@nvidia.com, yanjun.zhu@linux.dev,
marco.crivellari@suse.com, roman.gushchin@linux.dev,
phaddad@nvidia.com, lirongqing@baidu.com, ynachum@amazon.com,
huangjunxian6@hisilicon.com,
kalesh-anakkur.purayil@broadcom.com, ohartoov@nvidia.com,
michaelgur@nvidia.com, shayd@nvidia.com, edwards@nvidia.com,
sriharsha.basavapatna@broadcom.com,
andrew.gospodarek@broadcom.com, selvin.xavier@broadcom.com
Subject: Re: [PATCH rdma-next v5 03/15] RDMA/core: Introduce generic buffer descriptor infrastructure for umem
Date: Mon, 18 May 2026 17:27:41 +0200 [thread overview]
Message-ID: <agsv3fAVpqFdX52y@FV6GYCPJ69> (raw)
In-Reply-To: <CAHYDg1RXDuB91xDUW9cURq3hWfYeWabrBNKfXEZm6aHVbQi+9g@mail.gmail.com>
Mon, May 18, 2026 at 03:04:06PM +0200, jmoroni@google.com wrote:
>Hi,
>
>> +struct ib_umem *ib_umem_get_desc(struct ib_device *device,
>> + const struct ib_uverbs_buffer_desc *desc,
>> + int access)
>> +{
>> + struct ib_umem_dmabuf *umem_dmabuf;
>> +
>> + if (desc->reserved[0] || desc->reserved[1])
>> + return ERR_PTR(-EINVAL);
>> +
>> + switch (desc->type) {
>> + case IB_UVERBS_BUFFER_TYPE_DMABUF:
>> + umem_dmabuf = ib_umem_dmabuf_get_pinned(device, desc->addr,
>> + desc->length, desc->fd,
>> + access);
>
>This all looks good to me. Just thinking out loud...
>
>Is there a longer term plan to handle revocable dmabufs on this path and
>get rid of the separate ib_umem_dmabuf_get methods?
Out of scope now.
next prev parent reply other threads:[~2026-05-18 15:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-17 6:29 [PATCH rdma-next v5 00/15] RDMA: Introduce generic buffer descriptor infrastructure for umem Jiri Pirko
2026-05-17 6:29 ` [PATCH rdma-next v5 01/15] RDMA/umem: Rename ib_umem_get() to ib_umem_get_va() Jiri Pirko
2026-05-17 6:29 ` [PATCH rdma-next v5 02/15] RDMA/umem: Split ib_umem_get_va() into a thin wrapper around __ib_umem_get_va() Jiri Pirko
2026-05-17 6:29 ` [PATCH rdma-next v5 03/15] RDMA/core: Introduce generic buffer descriptor infrastructure for umem Jiri Pirko
2026-05-18 13:04 ` Jacob Moroni
2026-05-18 15:27 ` Jiri Pirko [this message]
2026-05-18 18:01 ` Jason Gunthorpe
2026-05-17 6:29 ` [PATCH rdma-next v5 04/15] RDMA/umem: Route ib_umem_get_va() through ib_umem_get() Jiri Pirko
2026-05-17 6:29 ` [PATCH rdma-next v5 05/15] RDMA/uverbs: Push out CQ buffer umem processing into a helper Jiri Pirko
2026-05-17 6:29 ` [PATCH rdma-next v5 06/15] RDMA/uverbs: Add CQ buffer UMEM attribute and driver helpers Jiri Pirko
2026-05-17 6:29 ` [PATCH rdma-next v5 07/15] RDMA/efa: Use ib_umem_get_cq_buf() for user CQ buffer Jiri Pirko
2026-05-17 6:29 ` [PATCH rdma-next v5 08/15] RDMA/mlx5: Use ib_umem_get_cq_buf_or_va() " Jiri Pirko
2026-05-17 6:30 ` [PATCH rdma-next v5 09/15] RDMA/bnxt_re: " Jiri Pirko
2026-05-17 6:30 ` [PATCH rdma-next v5 10/15] RDMA/mlx4: Use ib_umem_get_cq_buf() " Jiri Pirko
2026-05-17 6:30 ` [PATCH rdma-next v5 11/15] RDMA/uverbs: Remove legacy umem field from struct ib_cq Jiri Pirko
2026-05-17 6:30 ` [PATCH rdma-next v5 12/15] RDMA/uverbs: Use UMEM attributes for QP creation Jiri Pirko
2026-05-17 6:30 ` [PATCH rdma-next v5 13/15] RDMA/mlx5: Use UMEM attributes for QP buffers in create_qp Jiri Pirko
2026-05-17 6:30 ` [PATCH rdma-next v5 14/15] RDMA/mlx5: Use UMEM attribute for CQ doorbell record Jiri Pirko
2026-05-17 6:30 ` [PATCH rdma-next v5 15/15] RDMA/mlx5: Use UMEM attribute for QP " Jiri Pirko
2026-05-18 13:30 ` [PATCH rdma-next v5 00/15] RDMA: Introduce generic buffer descriptor infrastructure for umem Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agsv3fAVpqFdX52y@FV6GYCPJ69 \
--to=jiri@resnulli.us \
--cc=andrew.gospodarek@broadcom.com \
--cc=edwards@nvidia.com \
--cc=gal.pressman@linux.dev \
--cc=huangjunxian6@hisilicon.com \
--cc=jgg@ziepe.ca \
--cc=jmoroni@google.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=lirongqing@baidu.com \
--cc=marco.crivellari@suse.com \
--cc=mbloch@nvidia.com \
--cc=michaelgur@nvidia.com \
--cc=mrgolin@amazon.com \
--cc=ohartoov@nvidia.com \
--cc=parav@nvidia.com \
--cc=phaddad@nvidia.com \
--cc=roman.gushchin@linux.dev \
--cc=selvin.xavier@broadcom.com \
--cc=shayd@nvidia.com \
--cc=sleybo@amazon.com \
--cc=sriharsha.basavapatna@broadcom.com \
--cc=yanjun.zhu@linux.dev \
--cc=ynachum@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox