From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59E8E370D7C for ; Tue, 2 Jun 2026 21:57:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780437451; cv=none; b=VwjqD3XjnPvKTZx2sjFqVdalUZFHRNDcN50trM+Z1neVaBdGbWR3QCzUTHlJuS1Rp0oJNNOGUOsggLZDNjBcFHQQPs2i82F/ZipCbzOEEoWBBx8NlJoPIlkbUWcknErspYKkbFHoG5iFHpkuVF/z1GEPsWLY1mKd+87R+0/sQ3k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780437451; c=relaxed/simple; bh=/uKj18xsSwzfXBhULeyb27nBNuJXAfpu5PbOw7oSUbY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EnNRth3bkOPnUAkjuoPGrk+0b2iwCN1oGBJfdqqY2PY1Dfd0Q3cT0Omcu6/1GeXA+xrjm6lhMg9/i4geERpYE97oUNWQp21m2K5XoyEU6uUeIQUGe76U5/GiGZo55KLwugrCpXRco8qrCBLKLtQVnhQCEPKq+UJwU3FJkhdt6fo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=q5Caw3+b; arc=none smtp.client-ip=209.85.208.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="q5Caw3+b" Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-396aacc5bcfso5807001fa.3 for ; Tue, 02 Jun 2026 14:57:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780437448; x=1781042248; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=bGjehcWp7844vjC/IZzW2WAoswJMDMGA6SPubuDrvD0=; b=q5Caw3+bqrQoiwiV3lESOlXfcgveGnsXhkBCjL/qGltLmKDl+MBIc0lSg30JxfHb8d UPqtphQrAfmj5MFxHLvG0ZcS7DECOPuoFosnkcxQt+CTZwvplueJFyB0dJb9B5rcwfx3 SgCkyXqJLOr3rVSOGKmuScxsHhSy6ZxUlNnSUyDxgnAW2k+4ji3uOixSz/fkvBeHbfAl BVkPr5Vxv8aFJC4Dy72S19RZ5/UcHf1vzZq8TUAb4wxurmQgLINMoO/rWjueyj/9+Q9r K8jGWWs0rk2kVyB3lMwmzh5PTRsenygVmxobXONU70YROkU2XhHU+sigk5V6Nj6p/ddA ulnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780437448; x=1781042248; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=bGjehcWp7844vjC/IZzW2WAoswJMDMGA6SPubuDrvD0=; b=k3/t99los3TqZhIQuhTJP1M4yuxx6bNyCyf4aDGqubVV2Qo8qmLbQHXL+gkpu1NWza HfMbkz/I1XSfLiF+1ueR2nfN8PCzqScQAxOPlziBtVZj1xpYNmHoPvBEumSY+VtLLqT5 sKcCeN7W07VA//cF28mBvgZIX3ZLmMBIFzJX2Iv0Uj9hqqXeSH9Ttis7lkjIQ9DK+KVQ 4PbItUl6CaSTGG/YCbsFie0P+uY3f1GvtAeRf6UhY8LuGE5JLIj8lCUkg9Te0XamXwM2 S+BLtKzUeHFcvZfYqPPeKvn0YrPzjN626FnaqnGV3yofffc/KcXPP068NsQ5vsC2t+Bv kF1g== X-Gm-Message-State: AOJu0YyOeXWILl9jU8N4PkrMg0k9z7ilFx9BbTIeHl9dbABv/zsyP2v5 hmikcvuwVY3qaIdXwy3Yz03WHz/v1uwYNwmqrG7Aj3lTa25vXRdCIcQm X-Gm-Gg: Acq92OH7nC+E6xQZT/u4ruA+TuYvbSS32NkoNpEHs869S0DgSh8Vk+sMg8cHRyOVdI2 6rN0tERWPSFCHBlZxJ/jtp/NvQ3ex78Gmj6p50cJgmCcYvM62IOVCUpXcEqeurzUOdl0tqZpLn7 ppKmaYzYjmNLesYNrz2+nWe+jXZTwWmGf6/S7m+gb17GjGLVcec4s7xC3HesA3mihWni8x8lxUf jBGzErg8RR8TgTaO8m1XsJA6xxCIfPOF1NOpssJasnjEo6CkmpNyG4FnWJBVlymwqfIe7YOUw95 wAjStdkAcKWDU5WHoH5CUA+SOxBsXBhCHDNxv2IGyCPijabGiYlN7F7Kel70G+BVWOqK+YCtx9g Fqoh0QviT+T4rLQUHehWnhRAVnKSzpQ/J/LrANRK/bng1Xid7WHj/SalOpfB7AHGROMlXYCGhB+ FJ+/V6qFsr+ioigOjZuZ0FYs6UNhvw7067Kr0= X-Received: by 2002:a05:6512:1513:20b0:5a8:5ca8:7f72 with SMTP id 2adb3069b0e04-5aa7c063ba8mr177399e87.4.1780437448240; Tue, 02 Jun 2026 14:57:28 -0700 (PDT) Received: from grain.localdomain ([5.18.255.97]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5aa7b97b042sm203357e87.47.2026.06.02.14.57.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2026 14:57:27 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id 5A2ED5A0061; Wed, 03 Jun 2026 00:57:27 +0300 (MSK) Date: Wed, 3 Jun 2026 00:57:27 +0300 From: Cyrill Gorcunov To: Jacob Moroni Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Tatyana Nikolova , Jason Gunthorpe , Leon Romanovsky Subject: Re: [PATCH] RDMA/irdma: Fix typo in SQ completions generation Message-ID: References: Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.3.1 (2026-03-20) On Tue, Jun 02, 2026 at 10:11:46AM -0400, Jacob Moroni wrote: > BTW, your fix matches the OOT driver code: > https://github.com/intel/ethernet-linux-irdma-and-idpf/blob/main/rdma-driver/src/irdma/utils.c#L3561 > Wow, didn't know about OOT driver :-) Thanks for pointing! > Regarding the "unrelated issue" - is it an irdma issue? Anything we > can help with? Well, the issue I'm dealing with is messy yet (i mean i'm not sure if it is irdma issue or not -- i'm loosing completions on posted operations when hardware in reset mode and same time the card is physically removed). Look, once I manage to collect all pieces of a problem I'll back with report ) At moment I suspect that we need to *flush* queue here instead of cancelling it --- static int irdma_destroy_qp(struct ib_qp *ibqp, struct ib_udata *udata) { struct irdma_qp *iwqp = to_iwqp(ibqp); struct irdma_device *iwdev = iwqp->iwdev; iwqp->sc_qp.qp_uk.destroy_pending = true; if (iwqp->iwarp_state == IRDMA_QP_STATE_RTS) irdma_modify_qp_to_err(&iwqp->sc_qp); if (!iwqp->user_mode) --> cancel_delayed_work_sync(&iwqp->dwork_flush);