From: Jiri Pirko <jiri@resnulli.us>
To: Leon Romanovsky <leon@kernel.org>
Cc: linux-rdma@vger.kernel.org, jgg@ziepe.ca, mrgolin@amazon.com
Subject: Re: [PATCH rdma-next v2 4/6] RDMA/uverbs: Add ioctl method for CQ resize
Date: Tue, 23 Jun 2026 12:26:21 +0200 [thread overview]
Message-ID: <ajpfNMfTpajyKWUx@FV6GYCPJ69> (raw)
In-Reply-To: <20260617110605.GV327369@unreal>
Wed, Jun 17, 2026 at 01:06:05PM +0200, leon@kernel.org wrote:
>On Mon, Jun 15, 2026 at 10:50:38AM +0200, Jiri Pirko wrote:
>> From: Jiri Pirko <jiri@nvidia.com>
>>
>> Resize CQ is currently only reachable through the legacy write()
>> uverbs command (IB_USER_VERBS_CMD_RESIZE_CQ). Add an equivalent modern
>> ioctl method, UVERBS_METHOD_CQ_RESIZE, on the CQ object so the
>> operation is available through the ioctl interface and can carry
>> per-attribute extensions. The handler mirrors the legacy command: it
>> looks up the CQ, calls resize_user_cq() and returns the new cqe count.
>> The legacy write path is left in place for ABI compatibility.
>
>I have a general question. Do we actually need CQ resizing, given that it is
>rarely implemented and often incorrect in existing drivers? Maybe this is a
>good time to consider deprecating that path.
Good question, turned out we can actually drop this.
next prev parent reply other threads:[~2026-06-23 10:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-15 8:50 [PATCH rdma-next v2 0/6] RDMA: add per-attribute UMEM for SRQ create and CQ resize Jiri Pirko
2026-06-15 8:50 ` [PATCH rdma-next v2 1/6] RDMA/uverbs: Add SRQ buffer UMEM attribute Jiri Pirko
2026-06-15 8:50 ` [PATCH rdma-next v2 2/6] RDMA/mlx5: Use UMEM attribute for SRQ buffer in create_srq Jiri Pirko
2026-06-15 8:50 ` [PATCH rdma-next v2 3/6] RDMA/mlx5: Use UMEM attribute for SRQ doorbell record Jiri Pirko
2026-06-15 8:50 ` [PATCH rdma-next v2 4/6] RDMA/uverbs: Add ioctl method for CQ resize Jiri Pirko
2026-06-17 11:06 ` Leon Romanovsky
2026-06-18 15:40 ` Dennis Dalessandro
2026-06-28 14:20 ` Leon Romanovsky
2026-06-23 10:26 ` Jiri Pirko [this message]
2026-06-15 8:50 ` [PATCH rdma-next v2 5/6] RDMA/uverbs: Add CQ resize buffer UMEM attribute Jiri Pirko
2026-06-15 8:50 ` [PATCH rdma-next v2 6/6] RDMA/mlx5: Use UMEM attribute for CQ resize buffer Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ajpfNMfTpajyKWUx@FV6GYCPJ69 \
--to=jiri@resnulli.us \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mrgolin@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox