From: Thomas Gleixner <tglx@linutronix.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: Weongyo Jeong <weongyo.linux@gmail.com>,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-scsi@vger.kernel.org,
Mike Marciniszyn <infinipath@intel.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH v1 0/2] genirq: support multiple IRQ notifier.
Date: Fri, 25 Mar 2016 21:49:51 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.11.1603252149120.3978@nanos> (raw)
In-Reply-To: <20160325193243.GA30485@infradead.org>
On Fri, 25 Mar 2016, Christoph Hellwig wrote:
> On Fri, Mar 25, 2016 at 08:51:51AM -0700, Weongyo Jeong wrote:
> > Each irq_desc only supports one IRQ affinity notifier at current
> > implementation so when we try to register another notifier, it silently
> > unregister previous entry and register new one.
> >
> > However the problem is that if CONFIG_RFS_ACCEL is set, at current
> > implementation no way to set additional IRQ affinity notifier for
> > some NIC cards RFS enabled because it already used for RFS.
> > With this patch we can register multiple IRQ affinity notifiers.
>
> The whole concept of these irq affinity notifiers seems wrong to me.
>
> If a device supports MSI-X it should simply request per-cpu or per-node
> vectors and we should prevent affinity changes for them.
You beat me to it. I'm having a half baken prototype to implement this at the
core level. Will post next week.
Thanks,
tglx
next prev parent reply other threads:[~2016-03-25 20:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-25 15:51 [PATCH v1 0/2] genirq: support multiple IRQ notifier Weongyo Jeong
[not found] ` <cover.1458920770.git.weongyo.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-03-25 15:51 ` [PATCH v1 1/2] genirq: clean up for irq_set_affinity_notifier() Weongyo Jeong
2016-03-25 19:32 ` [PATCH v1 0/2] genirq: support multiple IRQ notifier Christoph Hellwig
2016-03-25 20:49 ` Thomas Gleixner [this message]
[not found] ` <20160325193243.GA30485-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-03-28 18:19 ` Weongyo Jeong
2016-03-25 15:51 ` [PATCH v1 2/2] " Weongyo Jeong
2016-03-25 17:05 ` kbuild test robot
[not found] ` <150f84b627280fa9d4397e6a4cdb5d096bef70bd.1458920770.git.weongyo.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-03-25 18:58 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1603252149120.3978@nanos \
--to=tglx@linutronix.de \
--cc=hch@infradead.org \
--cc=infinipath@intel.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=weongyo.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox