From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 242D539E6FC for ; Wed, 12 Aug 2026 21:41:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786570895; cv=none; b=YxmqUoZe/SEJp1M0eD7a/GBjfKmSmBT5M+TaXR6vtO2v2C/HcVgau9qlTpfbnAKL+93kQLdCdHIiJ1rDjs69hxUYoAlTWdT0zZeu7BxjRON4KVzzzkp5y313qABE7N74l7piHnwJHbkHc6tVwxIDLy/y/iqD6Cl+wI01Pq6qD2A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786570895; c=relaxed/simple; bh=Myn0f5PoONuBeSnhGPwFLjCEATkMK/fQIXssiOVSNy0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=E/fBsEXkYVwURdQweBvJGtEYguLV1VjEeshYmrjZVvNZ9hAkxCV7tF8YMIKx+X0xtIs1LVIcEDNB6LEdsy4Sndt7cIKgHpn9UVbKfCUKqi1CIAvQDOvVtnWxy8AIOx/UJGymTNGnTLLz8RRSpN78+FSEKf1iIApNwaNkNlekfQo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=choYcLMz; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="choYcLMz" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-38e3efab7e0so299776a91.0 for ; Wed, 12 Aug 2026 14:41:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786570893; x=1787175693; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=NPvoXejEXMCOLtks/4P44XseBHeJ9j+rFY5G6V1i118=; b=choYcLMzzYt+EkneTOegz0/c40LRIGJvd4bO/SM6+11qBRjCZHyFmO+vsdAOFxsS1w EiFXkb4eR8TjF0JQdMn3RBqgg/nXvx0gBedu1SzsFJcl4U6vYEWZrfNp0A8MWJF8Fx2/ U/UEgb/kTjJEUR07MFRmoWAoNe5HDnLansO0wH3tlYyq/revCNq39mFPtxb0TpoqM9vH AYgxFm1KNabjVNnER7ZHZyUWclO/RwYCg7CeFztB5IgHuTbR+T3tUVfm1rzd+UDr7OXz v5dMxhIf8DGqcZlN39Hv939A46x5dcPthyVGFAW/Zn2jBSNQUufxPVWtYQkniVf/Dpus kAiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786570893; x=1787175693; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=NPvoXejEXMCOLtks/4P44XseBHeJ9j+rFY5G6V1i118=; b=AdVxl1wCQAVDxgRqwVOwFVQbKxSUBGNnVbMhrJ704Wb6s3TiquKzq7lnCrSiD3tUNl Q8/HuUuK0MDx+JgWRuFt5TBUPyVNZPB4NmcxK/VgYTJ2IAPBGMucvhrZc6brns/4RrqV oM4VAl38HPqu24lYpC4+Hi439MyJayka6ENCxE4hJdJkwHnSUa3BEklaifZFvnywESMe 0XlDpa8dU7uq8y0DLCVUn7lyRXg0mPGu/GVayAGTeyfU6Vu3fmYgtHQ2g4FSqIYRFCTV I0YRT104WLwWpW3qtFT6sMKXAmVIquQNFoQDVHmhIFHpN1rL3dr2L+ddi20htZvJKETf Hkkw== X-Forwarded-Encrypted: i=1; AHgh+Rr9yY8oLSRZHZDPWEhu8EiXg+u/mfIIyjxz4bknsnQIAmUJOPG/TiweSfpn/V/svICdckRTO5F6AS57@vger.kernel.org X-Gm-Message-State: AOJu0Yy+j5Mp9zLSVnFfoTpkrVNA8MZU/m7hySw7/99wlz5lmp8o1s9k 1d3VZ2rE5fcOPocsvwnRDh1yL+m113VQnBvIeLWsGe70YNTunsFN9MlUgyYmam0ozA== X-Gm-Gg: AR+sD132252wY9Dhm7fGLHeTBA30OtqUBgYxUxwYZV9MIr1V2a8ZoqyL6E8KBpWOzax TJ6bbYvTOyyfolOPqdpgY3XS+bbud29EskWP/UgzxUKgAIVt+ysIcIFqj+p86upnH7jph3nE803 Gvhg+E+SDMABqOY14KDPlT/0uhmX5bVDjIriigv6N4dQsA372V+pVNqf1bQ7ljZjY2R7Xt1sPlh QIbPIojC8wTXbjS4xCsYaBwW+2YHER9uCnuD6QbaAgfkVvDAm/eSHAoZhmW5ZG1Q1XAfe8y2E8g kKOog/FUGEwZDOj2ByTA4tPuRAvjirBWApxmbayNvLKWhsBkUPRjdzIVSWoDtHITrxbTYiNrXow 8NYecS8F9Nbth7qc2kXH/EXmlzaANCsBMX/4gTaJwyQlqq24WovSKmfpLp/+Nc3sjvZjpLB1dor XiRt6GHV+jJCsnIQYdt2aWEROIZ3I7rBcQW8misJ+QaigKH+lCvtr+R2rjZw/N1KAEoyPVLxQ3n HPUniQ3nyqRkRYiBdn/1ERJ9hevhQ== X-Received: by 2002:a17:90b:274c:b0:36b:de66:92c3 with SMTP id 98e67ed59e1d1-3931f583a5amr478962a91.10.1786570892837; Wed, 12 Aug 2026 14:41:32 -0700 (PDT) Received: from google.com (132.200.185.35.bc.googleusercontent.com. [35.185.200.132]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3931ced0781sm878738a91.11.2026.08.12.14.41.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 14:41:32 -0700 (PDT) Date: Wed, 12 Aug 2026 21:41:28 +0000 From: David Matlack To: Jason Gunthorpe Cc: Alex Williamson , kvm@vger.kernel.org, Leon Romanovsky , linux-kselftest@vger.kernel.org, linux-rdma@vger.kernel.org, Mark Bloch , netdev@vger.kernel.org, Saeed Mahameed , Shuah Khan , Tariq Toukan , patches@lists.linux.dev Subject: Re: [PATCH v4 08/10] vfio: selftests: Add mlx5 driver - HW init and command interface Message-ID: References: <0-v4-021df3fb5a3f+98e-mlx5st_jgg@nvidia.com> <8-v4-021df3fb5a3f+98e-mlx5st_jgg@nvidia.com> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8-v4-021df3fb5a3f+98e-mlx5st_jgg@nvidia.com> On 2026-08-12 11:59 AM, Jason Gunthorpe wrote: > diff --git a/tools/testing/selftests/vfio/lib/drivers/mlx5/mlx5_hw.h b/tools/testing/selftests/vfio/lib/drivers/mlx5/mlx5_hw.h > new file mode 100644 > index 00000000000000..a2506ec8a19523 > --- /dev/null > +++ b/tools/testing/selftests/vfio/lib/drivers/mlx5/mlx5_hw.h > @@ -0,0 +1,108 @@ > +/* SPDX-License-Identifier: GPL-2.0 OR Linux-OpenIB */ > +/* > + * mlx5 VFIO selftest driver - HW definitions > + * > + * Typed wrappers, constants, and helpers for programming mlx5 hardware > + * via the VFIO selftest framework. Most HW constants and all MLX5_SET/GET > + * macros come from the kernel headers (mlx5_ifc.h, mlx5_ifc_macros.h). > + */ > +#ifndef SELFTESTS_VFIO_MLX5_HW_H > +#define SELFTESTS_VFIO_MLX5_HW_H > + > +#include > +#include > +#include > + > +#include "mlx5_ifc.h" > +#include "mlx5_ifc_macros.h" I'm getting a compiler warning here when building with clang which is getting upgraded to error from -Werror. /usr/local/google/home/dmatlack/kernel/trees/review/tools/testing/selftests/vfio/lib/drivers/mlx5/mlx5_ifc.h:2706:50: error: field 'menu' with variable sized type 'struct mlx5_ifc_resource_dump_menu_segment_bits' not at the end of a struct or class is a GNU extension [-Werror,-Wgnu-variable-sized-type-not-at-end] 2706 | struct mlx5_ifc_resource_dump_menu_segment_bits menu; | ^ 1 error generated. make: *** [lib/libvfio.mk:36: I assume the mlx5 header needs to be fixed... But we can also work around it in VFIO selftests if that turns out to be a can of worms: diff --git a/tools/testing/selftests/vfio/lib/drivers/mlx5/mlx5_hw.h b/tools/testing/selftests/vfio/lib/drivers/mlx5/mlx5_hw.h index 2c451e411ec1..b9fad2b722a0 100644 --- a/tools/testing/selftests/vfio/lib/drivers/mlx5/mlx5_hw.h +++ b/tools/testing/selftests/vfio/lib/drivers/mlx5/mlx5_hw.h @@ -13,9 +13,18 @@ #include #include +#ifdef __clang__ +#pragma clang diagnostic push +#pragma clang diagnostic ignored "-Wgnu-variable-sized-type-not-at-end" +#endif + #include "mlx5_ifc.h" #include "mlx5_ifc_macros.h" +#ifdef __clang__ +#pragma clang diagnostic pop +#endif + /* * Typed HW object wrappers for driver region arrays. *