From: Yanjun Zhu <yanjun.zhu@linux.dev>
To: Daisuke Matsuda <matsuda-daisuke@fujitsu.com>,
jgg@nvidia.com, zyjzyj2000@gmail.com
Cc: linux-rdma@vger.kernel.org, rpearsonhpe@gmail.com, lizhijian@fujitsu.com
Subject: Re: [PATCH] RDMA/rxe: Remove an unused member from struct rxe_mr
Date: Fri, 26 Aug 2022 21:59:28 +0800 [thread overview]
Message-ID: <b02722ae-0eb9-0ba2-ea46-a15ec35426a2@linux.dev> (raw)
In-Reply-To: <20220826093453.854991-1-matsuda-daisuke@fujitsu.com>
在 2022/8/26 17:34, Daisuke Matsuda 写道:
> Commit 1e75550648da ("Revert "RDMA/rxe: Create duplicate mapping tables for
> FMRs"") brought back the member 'va' to struct rxe_mr. However, it is
> actually used by nobody and thus can be removed.
>
Missing Fixes?
Zhu Yanjun
> Signed-off-by: Daisuke Matsuda <matsuda-daisuke@fujitsu.com>
> ---
> drivers/infiniband/sw/rxe/rxe_mr.c | 1 -
> drivers/infiniband/sw/rxe/rxe_verbs.c | 1 -
> drivers/infiniband/sw/rxe/rxe_verbs.h | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_mr.c b/drivers/infiniband/sw/rxe/rxe_mr.c
> index 850b80f5ad8b..814116ec4778 100644
> --- a/drivers/infiniband/sw/rxe/rxe_mr.c
> +++ b/drivers/infiniband/sw/rxe/rxe_mr.c
> @@ -180,7 +180,6 @@ int rxe_mr_init_user(struct rxe_pd *pd, u64 start, u64 length, u64 iova,
> mr->access = access;
> mr->length = length;
> mr->iova = iova;
> - mr->va = start;
> mr->offset = ib_umem_offset(umem);
> mr->state = RXE_MR_STATE_VALID;
> mr->type = IB_MR_TYPE_USER;
> diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.c b/drivers/infiniband/sw/rxe/rxe_verbs.c
> index e264cf69bf55..9ebe9decad34 100644
> --- a/drivers/infiniband/sw/rxe/rxe_verbs.c
> +++ b/drivers/infiniband/sw/rxe/rxe_verbs.c
> @@ -1007,7 +1007,6 @@ static int rxe_map_mr_sg(struct ib_mr *ibmr, struct scatterlist *sg,
>
> n = ib_sg_to_pages(ibmr, sg, sg_nents, sg_offset, rxe_set_page);
>
> - mr->va = ibmr->iova;
> mr->iova = ibmr->iova;
> mr->length = ibmr->length;
> mr->page_shift = ilog2(ibmr->page_size);
> diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.h b/drivers/infiniband/sw/rxe/rxe_verbs.h
> index 96af3e054f4d..a51819d0c345 100644
> --- a/drivers/infiniband/sw/rxe/rxe_verbs.h
> +++ b/drivers/infiniband/sw/rxe/rxe_verbs.h
> @@ -305,7 +305,6 @@ struct rxe_mr {
> u32 rkey;
> enum rxe_mr_state state;
> enum ib_mr_type type;
> - u64 va;
> u64 iova;
> size_t length;
> u32 offset;
next prev parent reply other threads:[~2022-08-26 13:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 9:34 [PATCH] RDMA/rxe: Remove an unused member from struct rxe_mr Daisuke Matsuda
2022-08-26 13:59 ` Yanjun Zhu [this message]
2022-08-29 1:23 ` [PATCH v2] " Daisuke Matsuda
2022-08-29 6:48 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b02722ae-0eb9-0ba2-ea46-a15ec35426a2@linux.dev \
--to=yanjun.zhu@linux.dev \
--cc=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=lizhijian@fujitsu.com \
--cc=matsuda-daisuke@fujitsu.com \
--cc=rpearsonhpe@gmail.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).