Re: [PATCH RFC 12/12] RDMA/rtrs-srv: Remove kobject_del from rtrs_srv_destroy_once_sysfs_root_folders

Haris Iqbal
2022-11-14T16:23:41Z

On Sun, Nov 13, 2022 at 2:08 AM Guoqing Jiang <guoqing.jiang@linux.dev> wrote:
>
> The kobj_paths which is created dynamically by kobject_create_and_add,
> and per the comment above kobject_create_and_add, we only need to call
> kobject_put which is not same as other kobjs such as stats->kobj_stats
> and srv_path->kobj.
>
> Signed-off-by: Guoqing Jiang <guoqing.jiang@linux.dev>
Acked-by: Md Haris Iqbal <haris.iqbal@ionos.com>

Thanks

> ---
> drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c b/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c
> index da8e205ce331..c76ba29da1e2 100644
> --- a/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c
> +++ b/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c
> @@ -203,7 +203,6 @@ rtrs_srv_destroy_once_sysfs_root_folders(struct rtrs_srv_path *srv_path)
>
> mutex_lock(&srv->paths_mutex);
> if (!--srv->dev_ref) {
> - kobject_del(srv->kobj_paths);
> kobject_put(srv->kobj_paths);
> mutex_unlock(&srv->paths_mutex);
> device_del(&srv->dev);
> --
> 2.31.1
>