From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 666F4C56202 for ; Tue, 24 Nov 2020 20:27:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0E85A20678 for ; Tue, 24 Nov 2020 20:27:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="NF2NDSk+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730977AbgKXU1J (ORCPT ); Tue, 24 Nov 2020 15:27:09 -0500 Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:11401 "EHLO hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728047AbgKXU1I (ORCPT ); Tue, 24 Nov 2020 15:27:08 -0500 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Tue, 24 Nov 2020 12:27:11 -0800 Received: from [10.2.51.94] (172.20.13.39) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 24 Nov 2020 20:26:59 +0000 Subject: Re: [PATCH rdma-core 5/5] tests: Bug fix for get_access_flags() To: Jianxin Xiong , , CC: Doug Ledford , Jason Gunthorpe , "Leon Romanovsky" , Sumit Semwal , Christian Koenig , Daniel Vetter References: <1606153984-104583-1-git-send-email-jianxin.xiong@intel.com> <1606153984-104583-6-git-send-email-jianxin.xiong@intel.com> From: John Hubbard Message-ID: Date: Tue, 24 Nov 2020 12:26:59 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:83.0) Gecko/20100101 Thunderbird/83.0 MIME-Version: 1.0 In-Reply-To: <1606153984-104583-6-git-send-email-jianxin.xiong@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1606249631; bh=qa8LeVoIpKhbpCRzUIv/BMxsjcRjvgDjDP7iZ9jI1e0=; h=Subject:To:CC:References:From:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Language: Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy; b=NF2NDSk+14BaeA4F9zs2CfgEyLyUHJnf+3n4C8TdhnMuQ31Y98t8+dvUXm9cVBrxZ 78pCvEfgz0vSxEGPhI6o+P7oBoab0OmbiPNiSnT83rhmjeFwMTIedU6k3dSp9eOMu9 KL377M92Or44ZmtrVwYqCQHmhvOIyYYkY/A5VMZj8gF5K6PDHsDcMBj7kcLDSogBEs MJaKlHKnLSuX08ouLn/ZaI4DHTHSw1Q0feP08L3NqYCAoe+XhoQA7aXHcrbFblahhE O0dNdD0XS6Uop1frIWohAV84ynyFxEgZTZLVKeFshltykMAlk4ebMGbf7zshUVjHTu n/qrXYn29Fxpw== Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Just some silly nits I stumbled across while trying to understand the tests. On 11/23/20 9:53 AM, Jianxin Xiong wrote: > The filter defintion is wrong and causes get_access_flags() always definition > returning empty list. As the result the MR tests using this function > are effectively skipped (but report success). > > Also fix a typo in the comments. Was there another typo somewhere? All I see is an *added* typo... > > Signed-off-by: Jianxin Xiong > --- > tests/utils.py | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tests/utils.py b/tests/utils.py > index 0ad7110..eee44b4 100644 > --- a/tests/utils.py > +++ b/tests/utils.py > @@ -55,8 +55,8 @@ def filter_illegal_access_flags(element): > :param element: A list of access flags to check > :return: True if this list is legal, else False > """ > - if e.IBV_ACCESS_REMOTE_ATOMIC in element or e.IBV_ACCESS_REMOTE_WRITE: > - if e.IBV_ACCESS_LOCAL_WRITE: > + if e.IBV_ACCESS_REMOTE_ATOMIC in element or e.IBV_ACCESS_REMOTE_WRITE in element: > + if not e.IBV_ACCESS_LOCAL_WRITE in element: > return False > return True > > @@ -69,7 +69,7 @@ def get_access_flags(ctx): > added as well. > After verifying that the flags selection is legal, it is appended to an > array, assuming it wasn't previously appended. > - :param ctx: Device Context to check capabilities > + :param ctx: Device Coyyntext to check capabilities I liked the old spelling. "Coyyntext" just doesn't sound as good. :) > :param num: Size of initial collection > :return: A random legal value for MR flags > """ > thanks, -- John Hubbard NVIDIA