From: Jianbo Liu <jianbol@nvidia.com>
To: Chenguang Zhao <chenguang.zhao@linux.dev>,
Tariq Toukan <tariqt@nvidia.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
Cosmin Ratiu <cratiu@nvidia.com>,
Dragos Tatulea <dtatulea@nvidia.com>,
Gal Pressman <gal@nvidia.com>, Jason Gunthorpe <jgg@ziepe.ca>,
Jiri Pirko <jiri@resnulli.us>, Leon Romanovsky <leon@kernel.org>,
open list <linux-kernel@vger.kernel.org>,
linux-rdma@vger.kernel.org, Mark Bloch <mbloch@nvidia.com>,
Saeed Mahameed <saeedm@nvidia.com>, Shay Drori <shayd@nvidia.com>
Subject: Re: [PATCH net] net/mlx5: Attach late uplink netdev to loaded representors
Date: Fri, 16 Oct 2026 16:44:42 +0800 [thread overview]
Message-ID: <b4005276-fb1d-4e4f-8f03-487f9e9bf9e5@nvidia.com> (raw)
In-Reply-To: <20261016023609.GA318264@pc>
On 10/16/2026 10:36 AM, Chenguang Zhao wrote:
[...]
> I’m wondering if we could add a check during mode configuration to
> disallow mode switching when the device is unbound.
>
> Maybe we can call `mlx5_uplink_netdev_get()` within `mlx5_devlink_eswitch_mode_set()`
> to retrieve the netdev, and return `-ENODEV` if it comes back NULL.
> Hi Chenguang,
I don't think we should reject the mode change. A switchdev eswitch
without an uplink netdev is valid for our use cases.
The check is also racy, since eth can unbind right after it, and
eth may simply not have probed yet when a script sets switchdev
after mlx5_core probe.
Thanks,
Jianbo
prev parent reply other threads:[~2026-10-16 8:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-06 11:02 [PATCH net] net/mlx5: Attach late uplink netdev to loaded representors Tariq Toukan
2026-10-06 11:20 ` sashiko-bot
2026-10-08 11:02 ` netdev-bot+sashiko
2026-10-13 11:23 ` Paolo Abeni
2026-10-14 7:26 ` Jianbo Liu
2026-10-16 2:36 ` Chenguang Zhao
2026-10-16 8:44 ` Jianbo Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4005276-fb1d-4e4f-8f03-487f9e9bf9e5@nvidia.com \
--to=jianbol@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=chenguang.zhao@linux.dev \
--cc=cratiu@nvidia.com \
--cc=davem@davemloft.net \
--cc=dtatulea@nvidia.com \
--cc=edumazet@kernel.org \
--cc=gal@nvidia.com \
--cc=jgg@ziepe.ca \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=shayd@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox