From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0F55CCA483 for ; Tue, 28 Jun 2022 08:28:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244915AbiF1I2F (ORCPT ); Tue, 28 Jun 2022 04:28:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343982AbiF1I1l (ORCPT ); Tue, 28 Jun 2022 04:27:41 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2793F0C; Tue, 28 Jun 2022 01:27:39 -0700 (PDT) Received: from fraeml707-chm.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4LXHkl0stbz6GDGM; Tue, 28 Jun 2022 16:26:55 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml707-chm.china.huawei.com (10.206.15.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 28 Jun 2022 10:27:37 +0200 Received: from [10.126.174.22] (10.126.174.22) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 28 Jun 2022 09:27:36 +0100 Message-ID: Date: Tue, 28 Jun 2022 09:27:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v2 0/6] blk-mq: Add a flag for reserved requests series To: CC: , , , , , , , , , , , , , , , , , , References: <1655810143-67784-1-git-send-email-john.garry@huawei.com> From: John Garry In-Reply-To: <1655810143-67784-1-git-send-email-john.garry@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.126.174.22] X-ClientProxiedBy: lhreml726-chm.china.huawei.com (10.201.108.77) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On 21/06/2022 12:15, John Garry wrote: Hi Jens, about this series, would you be ok to pick this up for merging? Do you find the changes acceptable? Thanks, John > In [0] I included "blk-mq: Add a flag for reserved requests" to identify > if a request is 'reserved' for special handling. Doing this is easier than > passing a 'reserved' arg to the blk_mq_ops callbacks. Indeed, only 1x > timeout implementation or blk-mq iter function actually uses the > 'reserved' arg (or 3x if you count SCSI core and FNIC SCSI driver). So > this series drops the 'reserved' arg for these timeout and iter functions. > Christoph suggested that I try to upstream now. > > Differences to v1: > - Use "scsi_timeout" as name for SCSI timeout function and update docs > - Add RB tags (thanks!) > - Split out patch to drop local variables for 'reserved', as requested by > Bart > > Based on following: > 6dbcddf6e76b (block/for-5.20/block) block: bfq: Fix kernel-doc headers > > [0] https://lore.kernel.org/linux-scsi/1654770559-101375-1-git-send-email-john.garry@huawei.com/T/#m22aa9f89e55835edc2e650d43f7e3219a3a1a324 > > John Garry (6): > scsi: core: Remove reserved request time-out handling > blk-mq: Add a flag for reserved requests > blk-mq: Drop blk_mq_ops.timeout 'reserved' arg > scsi: fnic: Drop reserved request handling > blk-mq: Drop 'reserved' arg of busy_tag_iter_fn > blk-mq: Drop local variable for reserved tag > > Documentation/scsi/scsi_eh.rst | 3 +-- > Documentation/scsi/scsi_mid_low_api.rst | 2 +- > block/blk-mq-debugfs.c | 2 +- > block/blk-mq-tag.c | 13 +++++-------- > block/blk-mq.c | 22 +++++++++++++--------- > block/bsg-lib.c | 2 +- > drivers/block/mtip32xx/mtip32xx.c | 11 +++++------ > drivers/block/nbd.c | 5 ++--- > drivers/block/null_blk/main.c | 2 +- > drivers/infiniband/ulp/srp/ib_srp.c | 3 +-- > drivers/mmc/core/queue.c | 3 +-- > drivers/nvme/host/apple.c | 3 +-- > drivers/nvme/host/core.c | 2 +- > drivers/nvme/host/fc.c | 6 ++---- > drivers/nvme/host/nvme.h | 2 +- > drivers/nvme/host/pci.c | 2 +- > drivers/nvme/host/rdma.c | 3 +-- > drivers/nvme/host/tcp.c | 3 +-- > drivers/s390/block/dasd.c | 2 +- > drivers/s390/block/dasd_int.h | 2 +- > drivers/scsi/aacraid/comminit.c | 2 +- > drivers/scsi/aacraid/linit.c | 2 +- > drivers/scsi/fnic/fnic_scsi.c | 14 ++++---------- > drivers/scsi/hosts.c | 14 ++++++-------- > drivers/scsi/mpi3mr/mpi3mr_os.c | 16 ++++------------ > drivers/scsi/scsi_error.c | 6 +++--- > drivers/scsi/scsi_lib.c | 8 -------- > drivers/scsi/scsi_priv.h | 2 +- > include/linux/blk-mq.h | 10 ++++++++-- > include/scsi/scsi_host.h | 2 +- > 30 files changed, 71 insertions(+), 98 deletions(-) >