From: Gal Pressman <galpress@amazon.com>
To: Yishai Hadas <yishaih@dev.mellanox.co.il>
Cc: Yishai Hadas <yishaih@mellanox.com>, <linux-rdma@vger.kernel.org>,
<jgg@mellanox.com>, <dledford@redhat.com>, <saeedm@mellanox.com>,
<maorg@mellanox.com>, <michaelgur@mellanox.com>,
<netdev@vger.kernel.org>
Subject: Re: [PATCH rdma-next 07/10] RDMA/efa: Allow passing of optional access flags for MR registration
Date: Wed, 22 Jan 2020 09:51:32 +0200 [thread overview]
Message-ID: <b5540297-cc8d-c8fa-1934-a25f708e273c@amazon.com> (raw)
In-Reply-To: <89ddb3c3-a386-1aa4-e3e4-a4b0531b0978@dev.mellanox.co.il>
On 21/01/2020 18:57, Yishai Hadas wrote:
> On 1/21/2020 6:37 PM, Gal Pressman wrote:
>> On 08/01/2020 20:05, Yishai Hadas wrote:
>>> From: Michael Guralnik <michaelgur@mellanox.com>
>>>
>>> As part of adding a range of optional access flags that drivers need to
>>> be able to accept, mask this range inside efa driver.
>>> This will prevent the driver from failing when an access flag from
>>> that range is passed.
>>>
>>> Signed-off-by: Michael Guralnik <michaelgur@mellanox.com>
>>> Signed-off-by: Yishai Hadas <yishaih@mellanox.com>
>>> ---
>>> drivers/infiniband/hw/efa/efa_verbs.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/infiniband/hw/efa/efa_verbs.c
>>> b/drivers/infiniband/hw/efa/efa_verbs.c
>>> index 50c2257..b6b936c 100644
>>> --- a/drivers/infiniband/hw/efa/efa_verbs.c
>>> +++ b/drivers/infiniband/hw/efa/efa_verbs.c
>>> @@ -1370,6 +1370,7 @@ struct ib_mr *efa_reg_mr(struct ib_pd *ibpd, u64 start,
>>> u64 length,
>>> IB_ACCESS_LOCAL_WRITE |
>>> (is_rdma_read_cap(dev) ? IB_ACCESS_REMOTE_READ : 0);
>>> + access_flags &= ~IB_UVERBS_ACCESS_OPTIONAL_RANGE;
>>
>> Hi Yishai,
>> access_flags should be masked with IB_ACCESS_OPTIONAL instead of
>> IB_UVERBS_ACCESS_OPTIONAL_RANGE.
>>
>
> You are talking from namespace point of view, right ? both have same value.
>
> If it's important, can you send some patch to replace ?
I'll send a patch, thanks.
next prev parent reply other threads:[~2020-01-22 7:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 18:05 [PATCH rdma-next 00/10] Relaxed ordering memory regions Yishai Hadas
2020-01-08 18:05 ` [PATCH rdma-next 01/10] net/mlx5: Expose relaxed ordering bits Yishai Hadas
2020-01-08 18:05 ` [PATCH rdma-next 02/10] RDMA/core: Add UVERBS_METHOD_ASYNC_EVENT_ALLOC Yishai Hadas
2020-01-08 18:05 ` [PATCH rdma-next 03/10] RDMA/core: Remove ucontext_lock from the uverbs_destry_ufile_hw() path Yishai Hadas
2020-01-08 18:05 ` [PATCH rdma-next 04/10] RDMA/uverbs: Add ioctl command to get a device context Yishai Hadas
2020-01-08 18:05 ` [PATCH rdma-next 05/10] RDMA/uverbs: Verify MR access flags Yishai Hadas
2020-01-08 18:05 ` [PATCH rdma-next 06/10] RDMA/core: Add optional access flags range Yishai Hadas
2020-01-08 18:05 ` [PATCH rdma-next 07/10] RDMA/efa: Allow passing of optional access flags for MR registration Yishai Hadas
2020-01-21 16:37 ` Gal Pressman
2020-01-21 16:57 ` Yishai Hadas
2020-01-22 7:51 ` Gal Pressman [this message]
2020-01-08 18:05 ` [PATCH rdma-next 08/10] RDMA/uverbs: Add new relaxed ordering memory region access flag Yishai Hadas
2020-01-09 9:38 ` Sergei Shtylyov
2020-01-15 18:05 ` Jason Gunthorpe
2020-01-08 18:05 ` [PATCH rdma-next 09/10] RDMA/core: Add the core support field to METHOD_GET_CONTEXT Yishai Hadas
2020-01-08 18:05 ` [PATCH rdma-next 10/10] RDMA/mlx5: Set relaxed ordering when requested Yishai Hadas
2020-01-15 18:08 ` [PATCH rdma-next 00/10] Relaxed ordering memory regions Jason Gunthorpe
2020-01-16 9:20 ` Leon Romanovsky
2020-01-16 20:11 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5540297-cc8d-c8fa-1934-a25f708e273c@amazon.com \
--to=galpress@amazon.com \
--cc=dledford@redhat.com \
--cc=jgg@mellanox.com \
--cc=linux-rdma@vger.kernel.org \
--cc=maorg@mellanox.com \
--cc=michaelgur@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=yishaih@dev.mellanox.co.il \
--cc=yishaih@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox