Re: [PATCH v2 5/6] mm: track gup pages with page->dma_pinned_* fields

John Hubbard
2018-07-02T05:05:49Z

On 07/01/2018 07:58 PM, kbuild test robot wrote:
> Hi John,
>
> Thank you for the patch! Perhaps something to improve:
>
> [auto build test WARNING on linus/master]
> [also build test WARNING on v4.18-rc3]
> [cannot apply to next-20180629]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/john-hubbard-gmail-com/mm-fs-gup-don-t-unmap-or-drop-filesystem-buffers/20180702-090125
> config: x86_64-randconfig-x010-201826 (attached as .config)
> compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
> reproduce:
> # save the attached .config to linux build tree
> make ARCH=x86_64
>
> All warnings (new ones prefixed by >>):
>
> In file included from arch/x86/include/asm/atomic.h:5:0,
> from include/linux/atomic.h:5,
> from include/linux/page_counter.h:5,
> from mm/memcontrol.c:34:
> mm/memcontrol.c: In function 'unlock_page_lru':
> mm/memcontrol.c:2087:32: error: 'page_tail' undeclared (first use in this function); did you mean 'page_pool'?
> VM_BUG_ON_PAGE(PageDmaPinned(page_tail), page);
> ^
Yes, that should have been:

VM_BUG_ON_PAGE(PageDmaPinned(page), page);

Fixed locally...maybe I'll post a v3 right now, as there were half a dozen ridiculous typos that
snuck in.

thanks,
--
John Hubbard
NVIDIA