From: "santosh.shilimkar@oracle.com" <santosh.shilimkar@oracle.com>
To: Colin King <colin.king@canonical.com>,
"David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
rds-devel@oss.oracle.com
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][rds-next] rds: make functions rds_info_from_znotifier and rds_message_zcopy_from_user static
Date: Sun, 11 Mar 2018 23:54:56 -0700 [thread overview]
Message-ID: <b693b404-3c66-5c45-4610-e119956c8dff@oracle.com> (raw)
In-Reply-To: <20180311170340.27696-1-colin.king@canonical.com>
On 3/11/18 10:03 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Functions rds_info_from_znotifier and rds_message_zcopy_from_user are
> local to the source and do not need to be in global scope, so make them
> static.
>
> Cleans up sparse warnins:
> net/rds/message.c:70:27: warning: symbol 'rds_info_from_znotifier' was
> not declared. Should it be static?
> net/rds/message.c:358:5: warning: symbol 'rds_message_zcopy_from_user'
> was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> net/rds/message.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
next prev parent reply other threads:[~2018-03-12 6:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-11 17:03 [PATCH][rds-next] rds: make functions rds_info_from_znotifier and rds_message_zcopy_from_user static Colin King
2018-03-11 17:22 ` Sowmini Varadhan
2018-03-12 6:54 ` santosh.shilimkar [this message]
2018-03-12 7:04 ` santosh.shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b693b404-3c66-5c45-4610-e119956c8dff@oracle.com \
--to=santosh.shilimkar@oracle.com \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox