Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: Edward Srouji <edwards@nvidia.com>
To: sashiko-reviews@lists.linux.dev
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH rdma-next 07/11] RDMA/mlx5: Select the QP core device through its PD
Date: Sun, 22 Nov 2026 14:35:26 +0200	[thread overview]
Message-ID: <b8d363e1-da38-4f5a-9bb3-82722e75ce62@nvidia.com> (raw)
In-Reply-To: <sashiko-outbox-221136@kernel.org>



On 11/18/2026 4:04 PM, sashiko-bot@kernel.org wrote:
> External email: Use caution opening links or attachments
> 
> 
> Thank you for your contribution! Sashiko AI review found no new issues
> in this patch, but noticed 1 related pre-existing issue it does not
> introduce:
> - [Medium] RDMA/mlx5: invalid qp_type check for DCI in
>    configure_requester_scat_cqe() [1]
> --
> 
> commit fd0bed19b1450b572f53f3dc5f8db9cab84d4594
> Author: Akiva Goldberger <agoldberger@nvidia.com>
> 
> RDMA/mlx5: Select the QP core device through its PD
> 
> This commit resolves the mlx5_core_dev from the QP or its PD across the QP
> create, modify, query, and work request posting paths instead of accessing
> dev->mdev.
> 
>> diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c
>> index 2709e5465d331..1135e710e3398 100644
>> --- a/drivers/infiniband/hw/mlx5/qp.c
>> +++ b/drivers/infiniband/hw/mlx5/qp.c
> [ ... ]
>> @@ -1957,11 +1970,11 @@ static int create_rss_raw_qp_tir(struct mlx5_ib_dev *dev, struct ib_pd *pd,
>>        return err;
>>   }
>>
>> -static void configure_requester_scat_cqe(struct mlx5_ib_dev *dev,
>> -                                      struct mlx5_ib_qp *qp,
>> +static void configure_requester_scat_cqe(struct mlx5_ib_qp *qp,
>>                                         struct ib_qp_init_attr *init_attr,
>>                                         void *qpc)
>>   {
>> +     struct mlx5_core_dev *mdev = qp_to_mdev(qp);
>>        int scqe_sz;
>>        bool allow_scat_cqe = false;
>>
>> @@ -1977,7 +1990,7 @@ static void configure_requester_scat_cqe(struct mlx5_ib_dev *dev,
>>        }
>>
>>        if (init_attr->qp_type != MLX5_IB_QPT_DCI ||
>> -         MLX5_CAP_GEN(dev->mdev, dc_req_scat_data_cqe))
>> +         MLX5_CAP_GEN(mdev, dc_req_scat_data_cqe))
>>                MLX5_SET(qpc, qpc, cs_req, MLX5_REQ_SCAT_DATA32_CQE);
>>   }
> 
> [Severity: Medium]
> This problem wasn't introduced by this patch, but should this check
> qp->type != MLX5_IB_QPT_DCI instead of init_attr->qp_type [1]?
> 
> Since 2fdddbd5c966 ("RDMA/mlx5: Move DRIVER QP flags check into separate
> function"), process_vendor_flags() sets qp->type to MLX5_IB_QPT_DCI while
> leaving init_attr->qp_type as IB_QPT_DRIVER.  The condition
> init_attr->qp_type != MLX5_IB_QPT_DCI is always true, so creating a DCI QP
> with scatter CQE enabled and a 64-byte send CQE on hardware without
> dc_req_scat_data_cqe support sets cs_req to MLX5_REQ_SCAT_DATA32_CQE and
> causes the firmware CREATE_QP command to fail.
> 

This one is real. Will add it to our fixes queue since this patch has no 
functional change or effect.

> [1] https://sashiko.dev/#/bug/linux-c5534546-da56-41f8-bc32-0fc827b3c22e
> 
> --
> Sashiko AI review · https://sashiko.dev/#/patchset/20261117-mlx5-sd-prep-v1-0-8efd124c7895@nvidia.com?part=7


  reply	other threads:[~2026-11-22 12:35 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 14:01 [PATCH rdma-next 00/11] RDMA/mlx5: Preparation for SD support Edward Srouji
2026-11-17 14:01 ` [PATCH rdma-next 01/11] RDMA/mlx5: Enforce dev/mdev naming for device pointers Edward Srouji
2026-11-18 14:04   ` sashiko-bot
2026-11-22 10:43     ` Edward Srouji
2026-11-17 14:01 ` [PATCH rdma-next 02/11] RDMA/mlx5: Rename to_mdev() helpers that return an IB device Edward Srouji
2026-11-18 14:04   ` sashiko-bot
2026-11-22 10:59     ` Edward Srouji
2026-11-17 14:01 ` [PATCH rdma-next 03/11] RDMA/mlx5: Select the PD and SRQ core device through the PD Edward Srouji
2026-11-18 14:04   ` sashiko-bot
2026-11-17 14:01 ` [PATCH rdma-next 04/11] RDMA/mlx5: Select the core device through PD for QP commands Edward Srouji
2026-11-18 14:04   ` sashiko-bot
2026-11-22 12:31     ` Edward Srouji
2026-11-17 14:01 ` [PATCH rdma-next 05/11] RDMA/mlx5: Cache the MR core device and resolve the MW's via its PD Edward Srouji
2026-11-18 14:04   ` sashiko-bot
2026-11-22 12:32     ` Edward Srouji
2026-11-17 14:01 ` [PATCH rdma-next 06/11] RDMA/mlx5: Select the AH core device through their PD Edward Srouji
2026-11-18 14:04   ` sashiko-bot
2026-11-17 14:01 ` [PATCH rdma-next 07/11] RDMA/mlx5: Select the QP core device through its PD Edward Srouji
2026-11-18 14:04   ` sashiko-bot
2026-11-22 12:35     ` Edward Srouji [this message]
2026-11-17 14:01 ` [PATCH rdma-next 08/11] RDMA/mlx5: Resolve core device from ucontext for DEVX resources Edward Srouji
2026-11-18 14:04   ` sashiko-bot
2026-11-22 12:43     ` Edward Srouji
2026-11-17 14:01 ` [PATCH rdma-next 09/11] RDMA/mlx5: Cache the CQ core device and resolve it via cq_to_mdev() Edward Srouji
2026-11-18 14:04   ` sashiko-bot
2026-11-22 12:41     ` Edward Srouji
2026-11-17 14:01 ` [PATCH rdma-next 10/11] RDMA/mlx5: Resolve the bfreg UAR-index core device from the ucontext Edward Srouji
2026-11-18 14:04   ` sashiko-bot
2026-11-17 14:01 ` [PATCH rdma-next 11/11] RDMA/mlx5: Resolve UAR and mmap core devices via " Edward Srouji
2026-11-18 14:04   ` sashiko-bot
2026-11-22 10:32 ` [PATCH rdma-next 00/11] RDMA/mlx5: Preparation for SD support Edward Srouji

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b8d363e1-da38-4f5a-9bb3-82722e75ce62@nvidia.com \
    --to=edwards@nvidia.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox