From: Zhu Yanjun <yanjun.zhu@linux.dev>
To: Li Zhijian <lizhijian@fujitsu.com>, linux-rdma@vger.kernel.org
Cc: zyjzyj2000@gmail.com, jgg@ziepe.ca, leon@kernel.org,
linux-kernel@vger.kernel.org, rpearsonhpe@gmail.com
Subject: Re: [PATCH 1/2] RDMA/rxe: add missing newline to rxe_set_mtu message
Date: Wed, 23 Aug 2023 14:12:24 +0800 [thread overview]
Message-ID: <ba7f496c-b0af-6532-76c7-08eedea886ce@linux.dev> (raw)
In-Reply-To: <20230823021306.170901-1-lizhijian@fujitsu.com>
在 2023/8/23 10:13, Li Zhijian 写道:
> A newline help flushing message out.
rxe_info_dev will finally call printk to output information.
In this link
https://github.com/torvalds/linux/blob/master/Documentation/core-api/printk-basics.rst,
"
All printk() messages are printed to the kernel log buffer, which is a
ring buffer exported to userspace through /dev/kmsg. The usual way to
read it is using dmesg.
"
Do you mean that a new line will help the kernel log buffer flush
message out?
Zhu Yanjun
>
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
> ---
> drivers/infiniband/sw/rxe/rxe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe.c b/drivers/infiniband/sw/rxe/rxe.c
> index 54c723a6edda..cb2c0d54aae1 100644
> --- a/drivers/infiniband/sw/rxe/rxe.c
> +++ b/drivers/infiniband/sw/rxe/rxe.c
> @@ -161,7 +161,7 @@ void rxe_set_mtu(struct rxe_dev *rxe, unsigned int ndev_mtu)
> port->attr.active_mtu = mtu;
> port->mtu_cap = ib_mtu_enum_to_int(mtu);
>
> - rxe_info_dev(rxe, "Set mtu to %d", port->mtu_cap);
> + rxe_info_dev(rxe, "Set mtu to %d\n", port->mtu_cap);
> }
>
> /* called by ifc layer to create new rxe device.
next prev parent reply other threads:[~2023-08-23 6:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-23 2:13 [PATCH 1/2] RDMA/rxe: add missing newline to rxe_set_mtu message Li Zhijian
2023-08-23 2:13 ` [PATCH 2/2] RDMA/rxe: Call rxe_set_mtu after rxe_register_device Li Zhijian
2023-08-23 2:46 ` Daisuke Matsuda (Fujitsu)
2023-08-23 2:43 ` [PATCH 1/2] RDMA/rxe: add missing newline to rxe_set_mtu message Daisuke Matsuda (Fujitsu)
2023-08-23 3:04 ` Zhijian Li (Fujitsu)
2023-08-23 5:10 ` Daisuke Matsuda (Fujitsu)
2023-08-23 6:12 ` Zhu Yanjun [this message]
2023-08-23 6:25 ` Zhijian Li (Fujitsu)
2023-08-23 6:35 ` Zhu Yanjun
2023-08-23 6:47 ` Zhijian Li (Fujitsu)
2023-08-23 6:59 ` Zhu Yanjun
2023-08-23 7:20 ` Zhijian Li (Fujitsu)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba7f496c-b0af-6532-76c7-08eedea886ce@linux.dev \
--to=yanjun.zhu@linux.dev \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=lizhijian@fujitsu.com \
--cc=rpearsonhpe@gmail.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox