From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dennis Dalessandro Subject: Re: [PATCH for-next 3/7] IB/hfi1: Validate PKEY for incoming GSI MAD packets Date: Tue, 24 Oct 2017 15:49:57 -0400 Message-ID: References: <20171023125327.21191.31462.stgit@scvm10.sc.intel.com> <20171023130558.21191.30808.stgit@scvm10.sc.intel.com> <20171023183848.GC16127@mtr-leonro.local> <20171023193102.GE16127@mtr-leonro.local> <20171024145628.GA28224@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20171024145628.GA28224-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> Content-Language: en-US Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jason Gunthorpe Cc: Leon Romanovsky , dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Michael J. Ruhl" , Sebastian Sanchez List-Id: linux-rdma@vger.kernel.org On 10/24/2017 10:56 AM, Jason Gunthorpe wrote: > On Tue, Oct 24, 2017 at 10:02:23AM -0400, Dennis Dalessandro wrote: > >> Right, which doesn't say not to put it in a .c file. So I think the location >> is OK for this. However, whether it even needs to be an inline function at >> all in the first place is certainly a valid question. Let me chat with >> Sebastian and double check, if it doesn't really need to be inlined we'll >> send a v2. > > The general thinking is that the compiler is much better at deciding > if something should be inlined or not. For the case of 'static' the > compiler will always inline it if it makes sense. 'static inline' > disables that heuristic and forces the compiler to always inline.. > After talking with Sebastian, this doesn't need to be inlined after all. I will send a v2. -Denny -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html