From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67209C43331 for ; Fri, 6 Sep 2019 14:04:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2B74720854 for ; Fri, 6 Sep 2019 14:04:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b="VmXJAFC8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731251AbfIFOEW (ORCPT ); Fri, 6 Sep 2019 10:04:22 -0400 Received: from smtp-fw-2101.amazon.com ([72.21.196.25]:55342 "EHLO smtp-fw-2101.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727970AbfIFOEW (ORCPT ); Fri, 6 Sep 2019 10:04:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1567778662; x=1599314662; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=bIdnw9uuPcDo9ihD6iyWVZQQ5/HK01tfKep+VXopx/4=; b=VmXJAFC8Ft2b2PcQve9QQpah5phAeVctyaGQPCDJaeNoEX6R2wkA+Vg3 zR/62RfYxyg7S6CJBTvomdcyi6lPY4SAhwPOwqHx3sWps7oLAGho0rFT9 utTR9V7BpRVq+A84smLsfh6i3FCGoS//mpQ0Nh+/5sgodnmjDibXq9Sja 8=; X-IronPort-AV: E=Sophos;i="5.64,473,1559520000"; d="scan'208";a="749389855" Received: from iad6-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-2b-81e76b79.us-west-2.amazon.com) ([10.124.125.2]) by smtp-border-fw-out-2101.iad2.amazon.com with ESMTP; 06 Sep 2019 14:04:15 +0000 Received: from EX13MTAUEA001.ant.amazon.com (pdx4-ws-svc-p6-lb7-vlan3.pdx.amazon.com [10.170.41.166]) by email-inbound-relay-2b-81e76b79.us-west-2.amazon.com (Postfix) with ESMTPS id 0FE0BA2297; Fri, 6 Sep 2019 14:04:15 +0000 (UTC) Received: from EX13D19EUB003.ant.amazon.com (10.43.166.69) by EX13MTAUEA001.ant.amazon.com (10.43.61.243) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 6 Sep 2019 14:04:14 +0000 Received: from 8c85908914bf.ant.amazon.com (10.43.161.82) by EX13D19EUB003.ant.amazon.com (10.43.166.69) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 6 Sep 2019 14:04:11 +0000 Subject: Re: [PATCH] RDMA/siw: Fix page address mapping in TX path To: Bernard Metzler CC: , , References: <20190906084544.26103-1-bmt@zurich.ibm.com> From: Gal Pressman Message-ID: Date: Fri, 6 Sep 2019 17:04:06 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190906084544.26103-1-bmt@zurich.ibm.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.43.161.82] X-ClientProxiedBy: EX13P01UWA004.ant.amazon.com (10.43.160.127) To EX13D19EUB003.ant.amazon.com (10.43.166.69) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On 06/09/2019 11:45, Bernard Metzler wrote: > Use the correct kmap()/kunmap() flow to determine page > address used for CRC computation. Using page_address() > is wrong, since page might be in highmem. > > Reported-by: Krishnamraju Eraparaju > Fixes: b9be6f18cf9e rdma/siw: transmit path Hi Bernard, The format of the fixes line should be: Fixes: b9be6f18cf9e ("rdma/siw: transmit path")