Re: [RFC rdma-core 2/2] srp_daemon: fix CQ handling

Bart Van Assche
2017-12-11T16:30:09Z

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 763 bytes --]

On Mon, 2017-12-11 at 15:46 +0100, Nicolas Morey-Chaisemartin wrote:
> +tatic int poll_cq_once(struct sync_resources *sync_res, struct ibv_cq *cq,
> + struct ibv_wc *wc)

Has this patch been tested? I don't think that "tatic" is a valid keyword?

> + /* Poll CQ once. There may be extra completion that
> + * were associated to the previous event */
> + ret = poll_cq_once(sync_res, cq, wc);
> + if (ret)
> + return ret;

How many extra completions can be associated with an event? Is polling once
sufficient? If so, please update the comment ("an" is missing / "were" ->
"was").

Thanks,

Bart.N‹§²æìr¸›yúèšØb²X¬¶Ç§vØ^–)Þº{.nÇ+‰·¥Š{±­ÙšŠ{ayº\x1dÊ‡Ú™ë,j\a­¢f£¢·hš‹»öì\x17/oSc¾™Ú³9˜uÀ¦æå‰È&jw¨®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿïêäz¹Þ–Šàþf£¢·hšˆ§~ˆmš