From: Steve Wise <swise@opengridcomputing.com>
To: zhong jiang <zhongjiang@huawei.com>,
swise@chelsio.com, dledford@redhat.com, jgg@ziepe.ca
Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RDMA/cxgb4: remove redundant null pointer check before kfree_skb
Date: Thu, 20 Sep 2018 09:26:28 -0500 [thread overview]
Message-ID: <bed2c4a0-cb14-83cf-ad90-ce4e7def8b1a@opengridcomputing.com> (raw)
In-Reply-To: <1537437162-42846-1-git-send-email-zhongjiang@huawei.com>
On 9/20/2018 4:52 AM, zhong jiang wrote:
> kfree_skb has taken the null pointer into account. hence it is safe
> to remove the redundant null pointer check before kfree_skb.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> drivers/infiniband/hw/cxgb4/cm.c | 3 +--
> drivers/infiniband/hw/cxgb4/qp.c | 3 +--
> 2 files changed, 2 insertions(+), 4 deletions(-)
Acked-by: Steve Wise <swise@opengridcomputing.com>
next prev parent reply other threads:[~2018-09-20 14:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 9:52 [PATCH] RDMA/cxgb4: remove redundant null pointer check before kfree_skb zhong jiang
2018-09-20 14:26 ` Steve Wise [this message]
2018-09-21 16:03 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bed2c4a0-cb14-83cf-ad90-ce4e7def8b1a@opengridcomputing.com \
--to=swise@opengridcomputing.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=swise@chelsio.com \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).