From: bugzilla-daemon-590EEB7GvNiWaY/ihj7yzEB+6BGkLq7r@public.gmane.org
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [Bug 46051] New: mthca/mthca_cmd.c:1362: suspicious call to MTHCA_PUT
Date: Fri, 17 Aug 2012 08:47:42 +0000 (UTC) [thread overview]
Message-ID: <bug-46051-11804@https.bugzilla.kernel.org/> (raw)
https://bugzilla.kernel.org/show_bug.cgi?id=46051
Summary: mthca/mthca_cmd.c:1362: suspicious call to MTHCA_PUT
Product: Drivers
Version: 2.5
Kernel Version: 3.6-rc2
Platform: All
OS/Version: Linux
Tree: Mainline
Status: NEW
Severity: normal
Priority: P1
Component: Infiniband/RDMA
AssignedTo: drivers_infiniband-rdma-ztI5WcYan/vQLgFONoPN62D2FQJk+8+b@public.gmane.org
ReportedBy: dcb314-PkbjNfxxIARBDgjK7y7TUQ@public.gmane.org
Regression: No
I just ran the static analyser cppcheck over the source code of the
linux kernel version 3.6-rc2.
It said
[linux-3.6-rc2/drivers/infiniband/hw/mthca/mthca_cmd.c:1362]: (warning) Using
sizeof with a numeric constant as function argument might not be what you
intended.
The source code is
MTHCA_PUT(inbox, 0x1, INIT_HCA_FLAGS1_OFFSET);
The 2nd parameter to the macro looks suspicious.
All the other calls to MTHCA_PUT do not have a value.
Suggest code rework.
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
reply other threads:[~2012-08-17 8:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-46051-11804@https.bugzilla.kernel.org/ \
--to=bugzilla-daemon-590eeb7gvniway/ihj7yzeb+6bgklq7r@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).