From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Kaike Wan <kaike.wan@intel.com>,
Mike Marciniszyn <mike.marciniszyn@intel.com>,
Dennis Dalessandro <dennis.dalessandro@intel.com>,
Doug Ledford <dledford@redhat.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] IB/hfi1: Add missing break in switch statement
Date: Thu, 21 Feb 2019 15:26:22 -0600 [thread overview]
Message-ID: <c23934c8-94ed-e93c-9fe4-54eeed1586c4@embeddedor.com> (raw)
In-Reply-To: <20190221210902.GA25062@ziepe.ca>
On 2/21/19 3:09 PM, Jason Gunthorpe wrote:
> On Wed, Feb 20, 2019 at 07:02:33PM -0600, Gustavo A. R. Silva wrote:
>> Fix the following warning by adding a missing break:
>>
>> drivers/infiniband/hw/hfi1/tid_rdma.c: In function ‘hfi1_tid_rdma_wqe_interlock’:
>> drivers/infiniband/hw/hfi1/tid_rdma.c:3251:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> switch (prev->wr.opcode) {
>> ^~~~~~
>> drivers/infiniband/hw/hfi1/tid_rdma.c:3259:2: note: here
>> case IB_WR_RDMA_READ:
>> ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Fixes: c6c231175ccd ("IB/hfi1: Add interlock between TID RDMA WRITE and other requests")
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>> Reviewed-by: Kaike Wan <Kaike.wan@intel.com>
>> --
>> drivers/infiniband/hw/hfi1/tid_rdma.c | 1 +
>> 1 file changed, 1 insertion(+)
>
> Applied to for-next, thanks
>
Great. :)
Thank you both, Kaike and Jason.
--
Gustavo
prev parent reply other threads:[~2019-02-21 21:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 1:02 [PATCH] IB/hfi1: Add missing break in switch statement Gustavo A. R. Silva
2019-02-21 13:47 ` Wan, Kaike
2019-02-21 21:09 ` Jason Gunthorpe
2019-02-21 21:26 ` Gustavo A. R. Silva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c23934c8-94ed-e93c-9fe4-54eeed1586c4@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=dennis.dalessandro@intel.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=kaike.wan@intel.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox