linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tariq Toukan <ttoukan.linux@gmail.com>
To: Shay Drori <shayd@nvidia.com>,
	Mohith Kumar Thummaluru <mohith.k.kumar.thummaluru@oracle.com>,
	"saeedm@nvidia.com" <saeedm@nvidia.com>,
	"leon@kernel.org" <leon@kernel.org>,
	"tariqt@nvidia.com" <tariqt@nvidia.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: "andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"edumazet@google.com" <edumazet@google.com>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"pabeni@redhat.com" <pabeni@redhat.com>,
	"jacob.e.keller@intel.com" <jacob.e.keller@intel.com>,
	"elic@nvidia.com" <elic@nvidia.com>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Anand Khoje <anand.a.khoje@oracle.com>,
	Manjunath Patil <manjunath.b.patil@oracle.com>,
	Rama Nichanamatlu <rama.nichanamatlu@oracle.com>,
	Rajesh Sivaramasubramaniom
	<rajesh.sivaramasubramaniom@oracle.com>,
	Rohit Sajan Kumar <rohit.sajan.kumar@oracle.com>,
	Moshe Shemesh <moshe@nvidia.com>, Mark Bloch <mbloch@nvidia.com>,
	Qing Huang <qing.huang@oracle.com>
Subject: Re: [PATCH net 1/1] net/mlx5: Clean up only new IRQ glue on request_irq() failure
Date: Tue, 16 Sep 2025 22:53:26 +0300	[thread overview]
Message-ID: <c9533a24-a02a-4601-9b4d-197b03634c4f@gmail.com> (raw)
In-Reply-To: <d9bea817-279c-4024-9bff-c258371b3de7@nvidia.com>



On 16/09/2025 8:24, Shay Drori wrote:
> Hi, sorry for the late response :(
> 
> On 27/06/2025 9:50, Mohith Kumar Thummaluru wrote:
>> External email: Use caution opening links or attachments
>>
>>
..

> 
> now that the condition is only one line, you need to remove the
> parenthesis.
> 
> other than that.
> Reviewed-by: Shay Drory <shayd@nvidia.com>
> 

LGTM.

Acked-by: Tariq Toukan <tariqt@nvidia.com>


  reply	other threads:[~2025-09-16 19:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-27  6:50 [PATCH net 1/1] net/mlx5: Clean up only new IRQ glue on request_irq() failure Mohith Kumar Thummaluru
2025-07-02 17:58 ` Jacob Keller
2025-09-12  3:56   ` Pradyumn Rahar
2025-09-16  5:24 ` Shay Drori
2025-09-16 19:53   ` Tariq Toukan [this message]
2025-09-23  6:28   ` [PATCH net v2 " Pradyumn Rahar
2025-09-24 18:14     ` Keller, Jacob E
2025-09-28  5:55     ` Tariq Toukan
2025-10-27 14:29     ` Pradyumn Rahar
2025-11-03 11:37       ` Tariq Toukan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c9533a24-a02a-4601-9b4d-197b03634c4f@gmail.com \
    --to=ttoukan.linux@gmail.com \
    --cc=anand.a.khoje@oracle.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=elic@nvidia.com \
    --cc=jacob.e.keller@intel.com \
    --cc=kuba@kernel.org \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=manjunath.b.patil@oracle.com \
    --cc=mbloch@nvidia.com \
    --cc=mohith.k.kumar.thummaluru@oracle.com \
    --cc=moshe@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=qing.huang@oracle.com \
    --cc=rajesh.sivaramasubramaniom@oracle.com \
    --cc=rama.nichanamatlu@oracle.com \
    --cc=rohit.sajan.kumar@oracle.com \
    --cc=saeedm@nvidia.com \
    --cc=shayd@nvidia.com \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).