From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-186.mta1.migadu.com (out-186.mta1.migadu.com [95.215.58.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B00061E480 for ; Mon, 25 Nov 2024 23:32:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.186 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732577558; cv=none; b=Z6lV5ur9od0C2pRFrm1crIQ2bWrfcdzw2/Tw8T/CR+gOlInJBkjrZHVpmBCEcQywFH+wxsgDowrzUp0aqvvj1UY9+y1Vr/kkhSM1C7+baTj9rFIZaRuqOtviEUz3oUGbw0Nj087adimfnGRiWRsAbNj8ZeJfPyoWa1XoqehfcOw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732577558; c=relaxed/simple; bh=LNccCELnCrrqGQYbKuoIRwN1z+f7ffZ07hvTsR886aQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LKuTuVI+I8C2VuY9/9i80cnaZPXPK4InrS54gTOefsTOlhWLpoGlf/aJtE1Cv8wgvmg/R2FZqB56KkFf0JypC+Kgq6RueSLiXEN2Xqsc6rbt0mhjnhnbem3bDrDlVuJPAYIDPv4f7pj3b1n9cMwygsPSSMdZF7qp0uvQdP104x4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=I7XBtWgo; arc=none smtp.client-ip=95.215.58.186 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="I7XBtWgo" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1732577553; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=42xw4Y/QgzVishOExotOvnZ6629ZtF3nEkWEZ8DaPJ8=; b=I7XBtWgoi21uPDExAyXxP3I5eIHuuliAfUq7hNhg/Cq/gcVONaqN7oQbH45zuQNMGiQuwp ItBqM/JLGbbqmeYf0NyXLG+LNdZH4RjmrNSCS4iw+ujSERgIE1oGF1gXp3rDWV+JYpGJRP HJHchJs3puUNxIPSmMu6+FzGwU6MEy4= Date: Mon, 25 Nov 2024 15:32:25 -0800 Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH bpf-next 4/4] bpf/selftests: add simple selftest for bpf_smc_ops To: Zhu Yanjun , "D. Wythe" Cc: kgraul@linux.ibm.com, wenjia@linux.ibm.com, jaka@linux.ibm.com, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, pabeni@redhat.com, song@kernel.org, sdf@google.com, haoluo@google.com, yhs@fb.com, edumazet@google.com, john.fastabend@gmail.com, kpsingh@kernel.org, jolsa@kernel.org, guwen@linux.alibaba.com, kuba@kernel.org, davem@davemloft.net, netdev@vger.kernel.org, linux-s390@vger.kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, dtcccc@linux.alibaba.com References: <1729737768-124596-1-git-send-email-alibuda@linux.alibaba.com> <1729737768-124596-5-git-send-email-alibuda@linux.alibaba.com> <8c06240b-540b-472f-974f-d2db80d90c22@linux.dev> <0a8c2285-29c2-4a79-b704-c2baeac90b70@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Martin KaFai Lau Content-Language: en-US In-Reply-To: <0a8c2285-29c2-4a79-b704-c2baeac90b70@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT On 11/25/24 2:52 AM, Zhu Yanjun wrote: >>> # ./test_progs -t smc >>> #27/1    bpf_smc/load:OK >>> #27      bpf_smc:OK >>> Summary: 1/1 PASSED, 0 SKIPPED, 0 FAILED >>> >>> The above command is based on several kernel modules. After these dependent >>> kernel modules are loaded, then can run the above command successfully. >> >> This is indeed a problem, a better way may be to create a separate testing >> directory for SMC, and we are trying to do this. > > Got it. In the latest patch series, if a test program in sample/bpf can verify > this bpf feature, it is better than a selftest program in the directory tools/ > testing/selftests/bpf. > > I delved into this selftest tool. It seems that this selftest tool only makes > the basic checks. A test program in sample/bpf can do more. sample(s)/bpf? No new test should be added to samples/bpf which is obsolete. The bpf CI only runs tests under selftests/bpf. There is selftests/bpf/config to tell the bpf CI about what kconfig needs to turn on.