From: Maher Sanalla <msanalla@nvidia.com>
To: Leon Romanovsky <leon@kernel.org>, Jason Gunthorpe <jgg@nvidia.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH rdma-next] RDMA/uverbs: Propagate errors from rdma_lookup_get_uobject()
Date: Wed, 26 Feb 2025 14:36:17 +0200 [thread overview]
Message-ID: <ca363e7d-9c77-4014-8786-8b3ed8d89525@nvidia.com> (raw)
In-Reply-To: <20250223085226.GW53094@unreal>
On 23/02/2025 10:52, Leon Romanovsky wrote:
>
>
> On Thu, Feb 20, 2025 at 09:53:52AM -0400, Jason Gunthorpe wrote:
>> On Thu, Feb 20, 2025 at 11:06:52AM +0200, Leon Romanovsky wrote:
>>>> Mainly -EBUSY from FW command interface, so users can safely call again
>>>> to modify QP.
>>>
>>> Forget about this comment, I was distracted, and it is -EBUSY from
>>> uverbs_try_lock_object() and not from FW command interface.
>>
>> Userspace is doing something really wrong if it is triggering that..
>
> And right now, userspace isn't aware of it. Users will be aware of it, after
> we will return real error code and not mask everything under same -EINVAL.
>
Yes.
Currently, most libibverbs calls pass the kernel-masked return value
directly to the application.
Thanks.
> Thanks
>
>>
>> Jason
prev parent reply other threads:[~2025-02-26 12:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 13:52 [PATCH rdma-next] RDMA/uverbs: Propagate errors from rdma_lookup_get_uobject() Leon Romanovsky
2025-02-19 14:46 ` Jason Gunthorpe
2025-02-19 15:56 ` Leon Romanovsky
2025-02-19 17:53 ` Jason Gunthorpe
2025-02-20 6:59 ` Leon Romanovsky
2025-02-20 9:06 ` Leon Romanovsky
2025-02-20 13:53 ` Jason Gunthorpe
2025-02-23 8:52 ` Leon Romanovsky
2025-02-26 12:36 ` Maher Sanalla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca363e7d-9c77-4014-8786-8b3ed8d89525@nvidia.com \
--to=msanalla@nvidia.com \
--cc=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox