From: Dennis Dalessandro <dennis.dalessandro@intel.com>
To: Leon Romanovsky <leon@kernel.org>,
"Goldman, Adam" <adam.goldman@intel.com>
Cc: linux-rdma@vger.kernel.org, mike.marciniszyn@intel.com
Subject: Re: [PATCH] kernel-boot: Do not perform device rename on OPA devices
Date: Tue, 4 Feb 2020 10:26:22 -0500 [thread overview]
Message-ID: <cbc06c0c-400c-93e9-6ced-11b12927ea03@intel.com> (raw)
In-Reply-To: <20200204145657.GY414821@unreal>
On 2/4/2020 9:56 AM, Leon Romanovsky wrote:
> On Tue, Feb 04, 2020 at 08:55:20AM -0500, Goldman, Adam wrote:
>> From: "Goldman, Adam" <adam.goldman@intel.com>
>>
>> PSM2 will not run with recent rdma-core releases. Several tools and
>> libraries like PSM2, require the hfi1 name to be present.
>>
>> Recent rdma-core releases added a new feature to rename kernel devices,
>> but the default configuration will not work with hfi1 fabrics.
>>
>> Related opa-psm2 github issue:
>> https://github.com/intel/opa-psm2/issues/43
>
> Why don't you fix opa-psm2 and add required rdma-core version
> checks inside packaging spec files, like we have inside
> redhat/rdma-core.spec?
>
> Thanks
>
This is the way PSM has operated from day 1. It has been broken by this
rename stuff. Clearly not everyone is fan, [1] [2] of the rename.
Seems to me like we should revert back to the original behavior. However
in lieu of that let HW vendors opt out like what this patch from Adam does.
[1] https://marc.info/?l=linux-rdma&m=158082841016117&w=2
[2] https://marc.info/?l=linux-rdma&m=158082569215149&w=2
-Denny
next prev parent reply other threads:[~2020-02-04 15:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 13:55 [PATCH] kernel-boot: Do not perform device rename on OPA devices Goldman, Adam
2020-02-04 14:14 ` Honggang LI
2020-02-04 14:53 ` Leon Romanovsky
2020-02-04 14:59 ` Gal Pressman
2020-02-04 15:51 ` Leon Romanovsky
2020-02-04 14:56 ` Leon Romanovsky
2020-02-04 15:26 ` Dennis Dalessandro [this message]
2020-02-04 15:53 ` Leon Romanovsky
2020-02-05 19:12 ` Jason Gunthorpe
2020-02-05 19:22 ` Leon Romanovsky
2020-02-05 20:35 ` Dennis Dalessandro
2020-02-05 20:54 ` Jason Gunthorpe
2020-02-05 21:59 ` Dennis Dalessandro
2020-02-06 13:52 ` Jason Gunthorpe
2020-02-06 17:51 ` Dennis Dalessandro
2020-02-06 18:22 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbc06c0c-400c-93e9-6ced-11b12927ea03@intel.com \
--to=dennis.dalessandro@intel.com \
--cc=adam.goldman@intel.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox