From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.180 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794776354; b=j2OlRTW6VMieYEMeYOx3oOY2fyHm/+Tl5OvzZaY2E2uupIE6/HMWb9jq2SSJX7K9+kCy rLOTbFSX250hmOGgxxTvUIVlM3I14o++jYZ31P+Q0HCKwrA0CAgsbbHzo9QQMl7d9VFDm P6paSO4UCsKvBFKfLbgKfHEUFEUaR5ZwozSvW8nVnKUmaeDtbxALyKEl+OgZzZMZCZ1JE eBq1J2rMGN6qX2iEQrctMsFowUOwOyyAlUmQZ+YTw1S9+za8CrSVtDGrxENsgVSki6K1o BBJ2qCFj7NOoOb41EkIlz0kYseHCqX+EPPIYZpguCqsBKkiXpxSRroAy28/pw1ZyUUQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794776354; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding; bh=OSA4KWND5TQ05YE5/BgdoX8/OyyIe/X6PGTfGzhUEYU=; b=MfQAMMroaRKQSqwPa0YVMqKPollpspmZPHuMqtTOdRiNtvPsxuvdyhsY5lkqYAGyCv9B /t0ldGGCvpEh24jJUcJrpblxvxLWae1WABq/PfpPw85QyjZUTh4YSEfQljiNw9KGXPNGj XZz1HpaU9U+wdV3GaKr3PHtHwa+6aK5BQsJHhfoPkkj2ZFb8GBq9MGtkebWo/BeDbuVqA +sAksMYyKZAUdbdQJX+Sq5/L5lKwPNJX4T6YCBsiduiv0OKd0sKa0HjOwKPpppT3ztRvL ynvnhVIYpAIG8qwaZPOG0OIFzVVkalwnTF2CBUR6uICbuT9zWwrHQ7n7E+Z5/rbH9xg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=QhJZICFu; arc=none smtp.remote-ip=209.85.128.180 Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29BE2606A31F for ; Sun, 15 Nov 2026 20:59:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 29BE2606A31F Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=QhJZICFu Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-8b3402105b9so20169847b3.0 for ; Sun, 15 Nov 2026 12:59:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794776353; x=1795381153; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=OSA4KWND5TQ05YE5/BgdoX8/OyyIe/X6PGTfGzhUEYU=; b=QhJZICFuCX0Ir7QVkDno0a5nNP6Uh0X662PROz4NaQBihwFiAtqR40VMSOdjyjvcve FEo2d4WPi6qku6sr0xseKPsx/w+BfEQFiG6x5a86WNbtkVtT2Ker2LRKzmJ/0VtnMbET vtrp8f0U929gP3WovWTJw9+FC5NK16ZkCYkgB6IIBg6Pd3BR5PgY0g7Vedg154Kj9ydP Aoni0QRV0ImTmMmeDWOdX4+x43z0wXE+/w8nxPOBIqOI6kXgB/ab/YghlZOYRoxZQy45 HB1qqwzSKgh59VWQCah//MzurjwIM3V56juArcgxpYfeUxA5qJMKX25q/zDOzz+z+jxL sabQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794776353; x=1795381153; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OSA4KWND5TQ05YE5/BgdoX8/OyyIe/X6PGTfGzhUEYU=; b=F0JqloH/qLJhYd38BKfRhpn7gEsCi23bc2Q/7lhtkynAfTkVTHpnea2u97xDe4MoYn bUqeZVoiDuWureG6ToooS0cnzN1ue5RzDDeJlercrLN8+U6vhP456LGCIxuziFNKLDOQ 00Yv4C5dlVBwuem1M/nACv8M7sy36fg2WndZroN6LolEbS7MoB2JhcBRZZ85/rG7m6fk 98ZePAAI7krfO0qWW48h3hohfliKTSTTRJwvuEQLjsD51p5N7VFp48pHxBzzUaZgbDeP Y71p8/2Gra+eREx0bW7HEgOGP68R34ADNOXl6dJol2bZstIuDFvP5gxE2vtlFLHS96kX cZbg== X-Forwarded-Encrypted: i=1; AL+hErHxI6Q0IZFUqr2AXk97PuZ6FIYQ83GKgcu5pqzzTv7vex9QdV9DGGNDMyuA8OQ1ZVfQ43QQNaNQFr+H@vger.kernel.org X-Gm-Message-State: APuU4Z9kEHJsCSw7qhglBvJtb+vO3YU86cOi0L0O2Z8LwHf163myn26j 8IzuEBeroznV0gR6Q1tKDnRiqM7MFZcogp3fkktQafwqxTPrXOdeZm8I X-Gm-Gg: AYBFou0zqs2iUEjujlsxoS+Ii537nuIXWYIrkCisn8H9povSKYPEj/cKj8eplltFhVI RXuRTdHmC79KUXPFqaRH6BiFU+65QfxfGeEc9ZaxcZKNTMDC1NDHds4jrwyFw/KexyFrd73/eOF maMMlS0B7pw5+OlFJIo7ZXj0XdhXSgwfX4Bne466cm29eoPCgrOcsLQfAOm3/L5INq6S8aYyLD4 Kqf2xK/XCDFj7ahBOYfUT3kKn+icBBp2tBdofOkCAMAw5h9WqXDhJmin0p553OPNl7lcfOn11vo wi43loSYz40mQGaZmhy9VkF9nw6sc8n80GcW+Nqy+oQ7VSCBsX8ICypK3A9Kc2m2Fx1ETNbCsLS 4/QrXwAU5OEL45hqVIbjXtqdpU9NdqksR7P+SK+1O4XlySibeQFSPyT4Xn4NSgw587y90rBbfiS hfGAlMBnByyUfyz4RO95LCbiOsXHa63chpiCSJDjAwMURdOqUq+w0zCNweT/b0m0vnSZId4gnAg DzAerkm6IInrsvUzZN3IwAFCeYVZlAs3gjUefkgIYDsg8da213xOTcbU+lbTpoldyuRcQD5b28q PKafAmPZvfpQ/8Pkh3X3UQncxmXPeV0nkPXuALTB8nUunMrEoeeI3Q9urYm2ZaiNcnRFlEzDToG U1+DYEa0I+sd4/+D+SV5XI0OCuzWqRSMqeGuQVr1vPczqxVa2yYlF X-Received: by 2002:a05:690c:386:b0:8b0:f116:1200 with SMTP id 00721157ae682-8b4aa35a461mr43071707b3.85.1794776353242; Sun, 15 Nov 2026 12:59:13 -0800 (PST) Received: from [192.168.4.64] (76-224-22-216.lightspeed.sntcca.sbcglobal.net. [76.224.22.216]) by smtp.gmail.com with ESMTPSA id 00721157ae682-8b4aa933d5esm71793097b3.19.2026.11.15.12.59.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 15 Nov 2026 12:59:12 -0800 (PST) Message-ID: Date: Sun, 15 Nov 2026 12:59:10 -0800 X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v4] net/mlx5e: advertise tcp-data-split support To: Nimrod Oren , "David S. Miller" Cc: Saeed Mahameed , Tariq Toukan , Mark Bloch , Leon Romanovsky , Andrew Lunn , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Gal Pressman , Cosmin Ratiu , Dragos Tatulea , Carolina Jubran , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , "netdev@vger.kernel.org" , "linux-rdma@vger.kernel.org" References: <20261111170558.1654691-1-dimitri.daskalakis1@gmail.com> Content-Language: en-US From: Dimitri Daskalakis In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/15/26 2:39 AM, Nimrod Oren wrote: > On 11/11/2026 19:05, Dimitri Daskalakis wrote: >> Changes in v4: >> - Nimrod and sashiko pointed out that not reporting DISABLED for >> tcp-data-split makes the feature look unsupported. This conflicted >> with my attempt to block users from setting DISABLED, locally sashiko >> found several scenarios where ring changes would get blocked. > > Can you please share those scenarios? > > I think blocking 'disabled' was the right direction. Allowing it doesn't > give users anything new, only a way to pin HW-GRO off, at the cost of > another dependency between the two knobs in mlx5e_fix_features(). > > We can still report 'disabled' when HW-GRO is supported but off. I should have saved the review, I reapplied v3 and added an else to disable tcp-data-split if the merge type is not SHAMPO, here's what sashiko reports. [Medium] Does this reject a value that get_ringparam reports? When HW-GRO is off, mlx5e_ethtool_get_ringparam() reports DISABLED. That is accurate, because SHAMPO is not in use. Before this patch, "ethtool -G eth0 tcp-data-split off" was accepted in that state. Now it fails with -EINVAL whatever the HW-GRO state is. This affects any netlink client that reads the rings config and writes the same attributes back. The whole request fails, including any ring size change sent with it. The changelog does not mention that existing users of "off" will break. A narrower fix may be possible. mlx5e_fix_features() could clear NETIF_F_GRO_HW when hds_config is DISABLED, like it already handles ENABLED. That would also fix the mis-reporting and keep DISABLED usable. Netlink users that call get then set with the received parameters will get a failure. This generally applies to users who save the current ring state, and try to revert back (via netlink or ethtool). A subsequent sashiko run highlighted the manual use case via ethtool. I recall sashiko had more severe feedback, but those cases may have been from the incorrect feature updates I fixed here [1]. The feedback is technically correct, though I'm not sure how much it matters in practice. v4 implements the narrower fix sashiko suggests, so it works for users who write back stored ring state. [1] https://patchwork.kernel.org/project/netdevbpf/patch/20261017005401.1582755-1-dimitri.daskalakis1@gmail.com/