From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EAABC433ED for ; Tue, 20 Apr 2021 20:55:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3C1DB613E7 for ; Tue, 20 Apr 2021 20:55:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233882AbhDTU41 (ORCPT ); Tue, 20 Apr 2021 16:56:27 -0400 Received: from gateway33.websitewelcome.com ([192.185.146.130]:29232 "EHLO gateway33.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233769AbhDTU40 (ORCPT ); Tue, 20 Apr 2021 16:56:26 -0400 X-Greylist: delayed 1505 seconds by postgrey-1.27 at vger.kernel.org; Tue, 20 Apr 2021 16:56:26 EDT Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 0F57DC78DA0 for ; Tue, 20 Apr 2021 15:10:08 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id YwhElE0X0w11MYwhElhzPj; Tue, 20 Apr 2021 15:10:08 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=T17AR9OHg8qWguPD0J0elr1lqd2smiUTolFswCJAyeE=; b=jQv1GMuu077q+yr2ApeKRPnqFG tsMh+lvGaFmsQ34LLZzAiiaMs2XD7/RCguH8/bk/WIU0MMLRvQ9XXv7NaP1sxKaT+aHOkFZWVQ9Ks af6TwikMt8WF9nYbVo1NtLINT9o0LuB5RTjOvxDRUCEKa6xDGnHE4hUMbhs45ghfWNrBlaYqbnYAh es0Fz7K1Zu3HkQhpoc7ziffEQG1jzNPjbh7jeCROfAKO3ZeKb69sYyAYl+dqEPq7Flaofqnwe+L/o qPCCQPMg/4ondAJGMWVr9XoGJ2Q3Dt2gDQfr5PmSQFYKdDObeidc3bGZ16ovUn0ZWqqvra5fzrvYH sXxbcrcA==; Received: from 187-162-31-110.static.axtel.net ([187.162.31.110]:48946 helo=[192.168.15.8]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1lYwhA-002fLy-Gv; Tue, 20 Apr 2021 15:10:04 -0500 Subject: Re: [PATCH RESEND][next] rds: Fix fall-through warnings for Clang To: "Gustavo A. R. Silva" , Santosh Shilimkar , "David S. Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org References: <20210305090612.GA139288@embeddedor> From: "Gustavo A. R. Silva" Message-ID: Date: Tue, 20 Apr 2021 15:10:19 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210305090612.GA139288@embeddedor> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 187.162.31.110 X-Source-L: No X-Exim-ID: 1lYwhA-002fLy-Gv X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 187-162-31-110.static.axtel.net ([192.168.15.8]) [187.162.31.110]:48946 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 51 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Hi all, Friendly ping: who can take this, please? Thanks -- Gustavo On 3/5/21 03:06, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple > warnings by explicitly adding multiple break statements instead of > letting the code fall through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva > --- > net/rds/tcp_connect.c | 1 + > net/rds/threads.c | 2 ++ > 2 files changed, 3 insertions(+) > > diff --git a/net/rds/tcp_connect.c b/net/rds/tcp_connect.c > index 4e64598176b0..5461d77fff4f 100644 > --- a/net/rds/tcp_connect.c > +++ b/net/rds/tcp_connect.c > @@ -78,6 +78,7 @@ void rds_tcp_state_change(struct sock *sk) > case TCP_CLOSE_WAIT: > case TCP_CLOSE: > rds_conn_path_drop(cp, false); > + break; > default: > break; > } > diff --git a/net/rds/threads.c b/net/rds/threads.c > index 32dc50f0a303..1f424cbfcbb4 100644 > --- a/net/rds/threads.c > +++ b/net/rds/threads.c > @@ -208,6 +208,7 @@ void rds_send_worker(struct work_struct *work) > case -ENOMEM: > rds_stats_inc(s_send_delayed_retry); > queue_delayed_work(rds_wq, &cp->cp_send_w, 2); > + break; > default: > break; > } > @@ -232,6 +233,7 @@ void rds_recv_worker(struct work_struct *work) > case -ENOMEM: > rds_stats_inc(s_recv_delayed_retry); > queue_delayed_work(rds_wq, &cp->cp_recv_w, 2); > + break; > default: > break; > } >