[PATCH 0/2] update to autotools

[PATCH 0/2] update to autotools

[Yann Droneaud]

As part of update to configure.ac, please find two quite simple patches.

It should be applied to bring the build system a bit up to date
regarding autotools.

It works on Debian 6.0 (Squeeze) and Fedora 17 (Beefy Miracle),
but you might want to test on older systems ... I'm looking at you
Red Hat Enterprise Linux ... But ultimately it depends on the
release manager's host environment which is probably up to date :)

Yann Droneaud (2):
  configure: apply updates proposed by autoupdate
  configure: use automake's option "subdir-objects"

 configure.ac | 19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)

-- 
1.7.11.7

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/2] configure: apply updates proposed by autoupdate

[Yann Droneaud]

'autoupdate' is a tool to help developer to update configure.ac.

This patch apply a few fixes as suggested by autoupdate.

It was tested on Debian 6.0.7 (Squeeze) and Fedora 17 (Beefy Miracle).

Signed-off-by: Yann Droneaud <ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org>
---
 configure.ac | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/configure.ac b/configure.ac
index 8f79891..a1d5365 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1,7 +1,7 @@
 dnl Process this file with autoconf to produce a configure script.
 
-AC_PREREQ(2.57)
-AC_INIT(libibverbs, 1.1.6, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org)
+AC_PREREQ([2.67])
+AC_INIT([libibverbs],[1.1.6],[linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org])
 AC_CONFIG_SRCDIR([src/ibverbs.h])
 AC_CONFIG_AUX_DIR(config)
 AC_CONFIG_MACRO_DIR(config)
@@ -11,14 +11,12 @@ m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])])
 
 dnl Checks for programs
 AC_PROG_CC
-AC_GNU_SOURCE
+AC_USE_SYSTEM_EXTENSIONS
 AC_PROG_LN_S
-AC_PROG_LIBTOOL
-
 LT_INIT
 
 AC_ARG_WITH([valgrind],
-    AC_HELP_STRING([--with-valgrind],
+    AS_HELP_STRING([--with-valgrind],
         [Enable Valgrind annotations (small runtime overhead, default NO)]))
 if test x$with_valgrind = x || test x$with_valgrind = xno; then
     want_valgrind=no
@@ -84,9 +82,10 @@ fi
 AC_SUBST(LIBIBVERBS_VERSION_SCRIPT)
 
 AC_CACHE_CHECK(for .symver assembler support, ac_cv_asm_symver_support,
-    [AC_TRY_COMPILE(, [asm("symbol:\n.symver symbol, api@ABI\n");],
-        ac_cv_asm_symver_support=yes,
-        ac_cv_asm_symver_support=no)])
+    [AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]],
+        [[asm("symbol:\n.symver symbol, api@ABI\n");]])],
+        [ac_cv_asm_symver_support=yes],
+        [ac_cv_asm_symver_support=no])])
 if test $ac_cv_asm_symver_support = yes; then
     AC_DEFINE([HAVE_SYMVER_SUPPORT], 1, [assembler has .symver support])
 fi
-- 
1.7.11.7

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] configure: use automake's option "subdir-objects"

[Yann Droneaud]

Following advice in "Autotool Mythbuster" [1],
option subdir-objects can be used to have Makefiles
create object files in the same directory than
theirs source files.

It reduces clobbering in the build directory.

[1] "Autotool Mythbuster", by Diego Elio "Flameeyes" Petten`o
http://www.flameeyes.eu/autotools-mythbuster/automake/nonrecursive.html

Signed-off-by: Yann Droneaud <ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org>
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index a1d5365..231083c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -6,7 +6,7 @@ AC_CONFIG_SRCDIR([src/ibverbs.h])
 AC_CONFIG_AUX_DIR(config)
 AC_CONFIG_MACRO_DIR(config)
 AC_CONFIG_HEADER(config.h)
-AM_INIT_AUTOMAKE([foreign])
+AM_INIT_AUTOMAKE([foreign subdir-objects])
 m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])])
 
 dnl Checks for programs
-- 
1.7.11.7

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 0/2] update to autotools

[Yann Droneaud]

Hi,

Le 21.05.2013 02:26, Weiny, Ira a écrit :
> [PATCH 0/2] update to autotools How are these different (if at all)
> from the patches submitted by Jeff previously?
>

Patches from Jeff are already applied on libibverbs.
My patches apply on top to improve a bit the way autotools are used for 
libibverbs.

- use new names/constructs for autoconf macro
- use new feature for automake for cosmetic.

Regards.

-- 
Yann Droneaud
OPTEYA

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html