From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99752C432C0 for ; Tue, 3 Dec 2019 16:06:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7ABD02073C for ; Tue, 3 Dec 2019 16:06:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726741AbfLCQGv (ORCPT ); Tue, 3 Dec 2019 11:06:51 -0500 Received: from mx2.suse.de ([195.135.220.15]:51528 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725848AbfLCQGv (ORCPT ); Tue, 3 Dec 2019 11:06:51 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id AD9186A2F7; Tue, 3 Dec 2019 16:06:47 +0000 (UTC) Message-ID: Subject: Re: [PATCH v4 8/8] linux/log2.h: Use roundup/dow_pow_two() on 64bit calculations From: Nicolas Saenz Julienne To: Rob Herring Cc: Andrew Murray , Marc Zyngier , "linux-kernel@vger.kernel.org" , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Tariq Toukan , Frank Rowand , Florian Fainelli , "maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE" , Eric Anholt , Stefan Wahren , Shawn Lin , Heiko Stuebner , Christoph Hellwig , Marek Szyprowski , Robin Murphy , james.quinlan@broadcom.com, Matthias Brugger , Phil Elwell , Jeremy Linton , PCI , "moderated list:BROADCOM BCM2835 ARM ARCHITECTURE" , "Rafael J. Wysocki" , Len Brown , "David S. Miller" , Bjorn Helgaas , linux-acpi@vger.kernel.org, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , netdev , linux-rdma@vger.kernel.org, devicetree@vger.kernel.org, "open list:ARM/Rockchip SoC..." , Linux IOMMU Date: Tue, 03 Dec 2019 17:06:43 +0100 In-Reply-To: References: <20191203114743.1294-1-nsaenzjulienne@suse.de> <20191203114743.1294-9-nsaenzjulienne@suse.de> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-VHC+bPmpbRjqhnK2ykxw" User-Agent: Evolution 3.34.1 MIME-Version: 1.0 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org --=-VHC+bPmpbRjqhnK2ykxw Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Rob, On Tue, 2019-12-03 at 09:53 -0600, Rob Herring wrote: > On Tue, Dec 3, 2019 at 5:48 AM Nicolas Saenz Julienne > wrote: > > The function now is safe to use while expecting a 64bit value. Use it > > where relevant. >=20 > What was wrong with the existing code? This is missing some context. You're right, I'll update it. For most of files changed the benefit here is factoring out a common patter= n using the standard function roundup/down_pow_two() which now provides corre= ct 64bit results. As for of/device.c and arm64/iort.c it's more of a readability enhancement.= I consider it's easier to understand than the current calculation as it abstr= acts the math. > > Signed-off-by: Nicolas Saenz Julienne > > --- > > drivers/acpi/arm64/iort.c | 2 +- > > drivers/net/ethernet/mellanox/mlx4/en_clock.c | 3 ++- > > drivers/of/device.c | 3 ++- >=20 > In any case, >=20 > Acked-by: Rob Herring >=20 Thanks! Regards, Nicolas --=-VHC+bPmpbRjqhnK2ykxw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEErOkkGDHCg2EbPcGjlfZmHno8x/4FAl3miBMACgkQlfZmHno8 x/5s+Af/a2icSd66GHrsABoMtUfJXpQclSae81ThRP5Bfx6+mK4Ty4en3T+IxOK+ NPmneod0gjSfyqqQniFbEcmlKAd8wXyUnBCCi6urRvuqOWcw65h10DA3fQCivaOt NWn3FRWMlPZbBIAYr/XOcsdOOkbD+VaFE/PaBYmxU/rWaCLGMWpYYBhF/Vcm+ASd VPQ4g8AfxyGvQW9EgbmRTMC0k7kMP6qrpmgIjNWvUPyJ+8ytD2Zly2xvbVf9TqhX /PP/t19fWayTqhsg+B04K0aN0oriRqSFX44yvCOApKhLBSsF6Nyc40m2sreqKMYY 98kwrOrux/Fb3OeV/Wzdhhh8VhH+Sg== =4wmf -----END PGP SIGNATURE----- --=-VHC+bPmpbRjqhnK2ykxw--