From: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
To: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Max Gurtovoy <maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
shahar.salzman-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
joseph.r.gruher-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
mrybczyn-FNhOzJFKnXGHXe+LvDLADg@public.gmane.org,
vladimirk-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
oren-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH v2 2/2] IB/mlx5: set UMR wqe fence according to HCA cap
Date: Tue, 30 May 2017 13:51:33 +0300 [thread overview]
Message-ID: <d23a5a6f-bd9f-3b1a-34d5-25e8eb2a041c@grimberg.me> (raw)
In-Reply-To: <20170529160609.GA17751-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
Leon,
>> We don't fence those WR's.
>> Christoph just re-write it to be more intuitive code. I don't see logic
>> difference, am I wrong here ?
>
> A little bit, before Christoph's suggestion, we calculated fence for
> the paths which need such fence, after we will calculate for all paths.
Every WQE posted to a send queue must include a fence bit. All work
request posted on the send queue calculate the required fence, this
used to happen in finish_wqe call-sites with get_fence(), Christoph
just inlin'ed it.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-05-30 10:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-28 7:53 [PATCH v2 1/2] net/mlx5: Define interface bits for fencing UMR wqe Max Gurtovoy
[not found] ` <1495957991-19223-1-git-send-email-maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-05-28 7:53 ` [PATCH v2 2/2] IB/mlx5: set UMR wqe fence according to HCA cap Max Gurtovoy
[not found] ` <1495957991-19223-2-git-send-email-maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-05-28 9:07 ` Christoph Hellwig
[not found] ` <20170528090705.GM13083-jcswGhMUV9g@public.gmane.org>
2017-05-28 9:53 ` Max Gurtovoy
[not found] ` <19a1d347-91da-7e5f-8877-86772204a80a-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-05-29 10:05 ` Leon Romanovsky
[not found] ` <20170529100504.GZ17751-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-05-29 12:21 ` Max Gurtovoy
[not found] ` <89409b6d-466d-070a-7082-1f7bbb9ad7c7-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-05-29 16:06 ` Leon Romanovsky
[not found] ` <20170529160609.GA17751-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-05-30 10:51 ` Sagi Grimberg [this message]
[not found] ` <d23a5a6f-bd9f-3b1a-34d5-25e8eb2a041c-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-05-30 17:15 ` Leon Romanovsky
2017-05-30 10:48 ` Sagi Grimberg
[not found] ` <700d9410-56e7-d70f-9de4-87e4e37bca28-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-05-30 11:15 ` Max Gurtovoy
[not found] ` <9562e253-bc15-4ea1-3880-0430fd540410-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-05-30 11:22 ` Sagi Grimberg
[not found] ` <bcd8ef4b-60f9-34e4-a020-0d34407da61e-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-05-30 11:24 ` Max Gurtovoy
[not found] ` <e93ca49a-63d0-495f-1348-89d6fecf9f54-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-05-30 14:28 ` Sagi Grimberg
[not found] ` <ad73e8d4-f519-3f50-400f-905d075e5ceb-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-05-30 20:41 ` Max Gurtovoy
2017-05-28 9:14 ` [PATCH v2 1/2] net/mlx5: Define interface bits for fencing UMR wqe Christoph Hellwig
2017-06-01 22:51 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d23a5a6f-bd9f-3b1a-34d5-25e8eb2a041c@grimberg.me \
--to=sagi-nqwnxtmzq1alnmji0ikvqw@public.gmane.org \
--cc=hch-jcswGhMUV9g@public.gmane.org \
--cc=joseph.r.gruher-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=mrybczyn-FNhOzJFKnXGHXe+LvDLADg@public.gmane.org \
--cc=oren-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=shahar.salzman-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=vladimirk-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).