From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sagi Grimberg Subject: Re: [PATCH v2 2/2] IB/mlx5: set UMR wqe fence according to HCA cap Date: Tue, 30 May 2017 13:51:33 +0300 Message-ID: References: <1495957991-19223-1-git-send-email-maxg@mellanox.com> <1495957991-19223-2-git-send-email-maxg@mellanox.com> <20170528090705.GM13083@lst.de> <19a1d347-91da-7e5f-8877-86772204a80a@mellanox.com> <20170529100504.GZ17751@mtr-leonro.local> <89409b6d-466d-070a-7082-1f7bbb9ad7c7@mellanox.com> <20170529160609.GA17751@mtr-leonro.local> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170529160609.GA17751-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Leon Romanovsky , Max Gurtovoy Cc: Christoph Hellwig , linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, shahar.salzman-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, joseph.r.gruher-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, mrybczyn-FNhOzJFKnXGHXe+LvDLADg@public.gmane.org, vladimirk-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, oren-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org List-Id: linux-rdma@vger.kernel.org Leon, >> We don't fence those WR's. >> Christoph just re-write it to be more intuitive code. I don't see logic >> difference, am I wrong here ? > > A little bit, before Christoph's suggestion, we calculated fence for > the paths which need such fence, after we will calculate for all paths. Every WQE posted to a send queue must include a fence bit. All work request posted on the send queue calculate the required fence, this used to happen in finish_wqe call-sites with get_fence(), Christoph just inlin'ed it. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html