From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06C73C433B4 for ; Mon, 26 Apr 2021 18:47:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BF08661159 for ; Mon, 26 Apr 2021 18:47:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238063AbhDZSrr (ORCPT ); Mon, 26 Apr 2021 14:47:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:48440 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238045AbhDZSrr (ORCPT ); Mon, 26 Apr 2021 14:47:47 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D60BC60C3D; Mon, 26 Apr 2021 18:47:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619462825; bh=LzNTYbiIWhKMpW5wxTjs6p9h2s4HLvKp7YiHBdWNF1E=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=ONufhNyrHGrELeVqTZK15JxWEZhOmZWroNjNuCEbm8kztwgl4X/RNCKZFd2XgPNAD FhOitq6vSvhw46H2PPeJXVdjBO55yR7TR1cvVY/M2YZL71nhaX6tpPNIsgbq8shKGD PxfkTdK3RjjY5X4ue22IBdzXSqCfpvzMXpiYltxR5AqhQdEB8P9Jb71XNtnjh6PhyU YSvw4Qpy6aHsEQJseFqE/C9t0OcY+QtpGav4Bhf2GgIGKEvi1pp6IIVzwH86hoShu9 mebvy1lN067HjnP2ay0Ue/+9BLDl+u8GI4xlfyq/MGngWOParRAD9AEiVMFBpyBI8s Jpx1CVME6aeWg== Message-ID: Subject: Re: [PATCH net-next] net/mlx5: Fix some error messages From: Saeed Mahameed To: Jakub Kicinski , Leon Romanovsky Cc: Dan Carpenter , Yevgeny Kliteynik , linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-netdev Date: Mon, 26 Apr 2021 11:47:03 -0700 In-Reply-To: <20210426093314.5f73781e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> References: <20210426093314.5f73781e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Mon, 2021-04-26 at 09:33 -0700, Jakub Kicinski wrote: > On Sun, 25 Apr 2021 09:39:29 +0300 Leon Romanovsky wrote: > > > diff --git > > > a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_termtb > > > l.c > > > b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_termtb > > > l.c > > > index a81ece94f599..95f5c1a27718 100644 > > > --- > > > a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_termtb > > > l.c > > > +++ > > > b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_termtb > > > l.c > > > @@ -83,16 +83,16 @@ mlx5_eswitch_termtbl_create(struct > > > mlx5_core_dev *dev, > > >         ft_attr.autogroup.max_num_groups = 1; > > >         tt->termtbl = > > > mlx5_create_auto_grouped_flow_table(root_ns, &ft_attr); > > >         if (IS_ERR(tt->termtbl)) { > > > -               esw_warn(dev, "Failed to create termination table > > > (error %d)\n", > > > -                        IS_ERR(tt->termtbl)); > > > +               esw_warn(dev, "Failed to create termination table > > > (error %ld)\n", > > > +                        PTR_ERR(tt->termtbl)); > > If these are error pointers - perhaps %pe? no reason to use %pe, we know it is an err ptr at this point so just report PTR_ERR()