From: Sreedhar Kodali <srkodali-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
To: "Hefty, Sean" <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
pradeeps-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org
Subject: RE: [PATCH v2 4/4] rsockets: acknowledge completion queue events in batch
Date: Sat, 06 Sep 2014 07:52:39 +0530 [thread overview]
Message-ID: <d52658b2f68bc014103e655857096b4a@imap.linux.ibm.com> (raw)
In-Reply-To: <1828884A29C6694DAF28B7E6B8A8237399DC1B64-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
On 2014-09-05 23:31, Hefty, Sean wrote:
>> Expose '/unackcqe_default' variable so completion event
>> acknowledgment can be done in batch instead of singles
>> to minimize locking overheads.
>>
>> The default value of this variable is 1 so the existing
>> functionality is preserved. Having a higher value delays
>> acknowledging until the specified limit is reached for
>> retrieved completion events.
>
> I would rather just change the default behavior, rather than introduce
> more checks and options into the code.
Hi Sean,
That's indeed a good approach. But, we need to have an upper limit
before a batch of events is flushed. Can we decide limit based on
completion event queue size?
Thank You.
- Sreedhar
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-09-06 2:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 13:23 [PATCH v2 4/4] rsockets: acknowledge completion queue events in batch Sreedhar Kodali
[not found] ` <c144abfe27bd0bf36ff1e3c9c912d7c3-FJGp5E75HVmZamtmwQBW5tBPR1lH4CV8@public.gmane.org>
2014-09-05 18:01 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A8237399DC1B64-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-09-06 2:22 ` Sreedhar Kodali [this message]
[not found] ` <d52658b2f68bc014103e655857096b4a-FJGp5E75HVmZamtmwQBW5tBPR1lH4CV8@public.gmane.org>
2014-09-06 16:37 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A8237399DC36C7-Q3cL8pyY+6s64kNsxIetb7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-09-07 3:01 ` Sreedhar Kodali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d52658b2f68bc014103e655857096b4a@imap.linux.ibm.com \
--to=srkodali-23vcf4htsmix0ybbhkvfkdbpr1lh4cv8@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=pradeeps-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox