From: Saeed Mahameed <saeedm@nvidia.com>
To: "dan.carpenter@oracle.com" <dan.carpenter@oracle.com>,
"gustavoars@kernel.org" <gustavoars@kernel.org>
Cc: "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"leon@kernel.org" <leon@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net/mlx5: remove erroneous fallthrough
Date: Wed, 19 Aug 2020 19:29:52 +0000 [thread overview]
Message-ID: <d6eb19690bd2e996d9dfd33361a506af7c53b325.camel@nvidia.com> (raw)
In-Reply-To: <20200803154801.GC1726@embeddedor>
On Mon, 2020-08-03 at 10:48 -0500, Gustavo A. R. Silva wrote:
> On Mon, Aug 03, 2020 at 05:34:48PM +0300, Dan Carpenter wrote:
> > This isn't a fall through because it was after a return
> > statement. The
> > fall through annotation leads to a Smatch warning:
> >
> > drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c:246
> > mlx5e_ethtool_get_sset_count() warn: ignoring unreachable code.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>
Applied to net-next-mlx5
Thanks!
prev parent reply other threads:[~2020-08-19 19:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 14:34 [PATCH net-next] net/mlx5: remove erroneous fallthrough Dan Carpenter
2020-08-03 15:48 ` Gustavo A. R. Silva
2020-08-19 19:29 ` Saeed Mahameed [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6eb19690bd2e996d9dfd33361a506af7c53b325.camel@nvidia.com \
--to=saeedm@nvidia.com \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=gustavoars@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox