Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: "Li, Zhijian" <lizhijian@fujitsu.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Zhu Yanjun <zyjzyj2000@gmail.com>, <linux-rdma@vger.kernel.org>,
	Bob Pearson <rpearsonhpe@gmail.com>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] RDMA/rxe: Use kzalloc() to alloc map_set
Date: Mon, 23 May 2022 22:02:56 +0800	[thread overview]
Message-ID: <d956bac8-36a6-0148-6f9c-fa43c8c272a7@fujitsu.com> (raw)
In-Reply-To: <20220520144511.GA2302907@nvidia.com>


on 2022/5/20 22:45, Jason Gunthorpe wrote:
> On Wed, May 18, 2022 at 12:37:25PM +0800, Li Zhijian wrote:
>> Below call chains will alloc map_set without fully initializing map_set.
>> rxe_mr_init_fast()
>>   -> rxe_mr_alloc()
>>      -> rxe_mr_alloc_map_set()
>>
>> Uninitialized values inside struct rxe_map_set are possible to cause
>> kernel panic.
> If the value is uninitialized then why is 0 an OK value?
>
> Would be happier to know the exact value that is not initialized

Well, good question. After re-think of this issue, it seems this patch 
wasn't the root cause though it made the crash disappear in some extent.

I'm still working on the root cause :)

Thanks

Zhijian


>
> Jason



  reply	other threads:[~2022-05-23 14:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-18  4:37 [PATCH] RDMA/rxe: Use kzalloc() to alloc map_set Li Zhijian
2022-05-20 14:45 ` Jason Gunthorpe
2022-05-23 14:02   ` Li, Zhijian [this message]
2022-05-24  3:59     ` lizhijian
2022-05-24 10:56       ` Haris Iqbal
2022-05-25  1:31         ` lizhijian
2022-05-25  4:11           ` Guoqing Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d956bac8-36a6-0148-6f9c-fa43c8c272a7@fujitsu.com \
    --to=lizhijian@fujitsu.com \
    --cc=jgg@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=rpearsonhpe@gmail.com \
    --cc=zyjzyj2000@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox