From: Bart Van Assche <bvanassche@acm.org>
To: Sara Venkatesh <sarajvenkatesh@gmail.com>, jgg@ziepe.ca
Cc: leon@kernel.org, dledford@redhat.com, linux-rdma@vger.kernel.org,
target-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
carlos.bilbao@kernel.org
Subject: Re: [PATCH] RDMA/srpt: fix integer overflow in immediate data length check
Date: Mon, 4 May 2026 10:17:13 +0200 [thread overview]
Message-ID: <dbc57009-f563-4858-91f1-a63efe786d01@acm.org> (raw)
In-Reply-To: <20260504080036.3482415-1-sarajvenkatesh@gmail.com>
On 5/4/26 10:00 AM, Sara Venkatesh wrote:
> diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c
> index 9aec5d80117f..f66cfd70c263 100644
> --- a/drivers/infiniband/ulp/srpt/ib_srpt.c
> +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
> @@ -1129,9 +1129,10 @@ static int srpt_get_desc_tbl(struct srpt_recv_ioctx *recv_ioctx,
> struct srp_imm_buf *imm_buf = srpt_get_desc_buf(srp_cmd);
> void *data = (void *)srp_cmd + imm_data_offset;
> uint32_t len = be32_to_cpu(imm_buf->len);
> - uint32_t req_size = imm_data_offset + len;
> + uint32_t req_size;
>
> - if (req_size > srp_max_req_size) {
> + if (check_add_overflow((uint32_t)imm_data_offset, len, &req_size) ||
> + req_size > srp_max_req_size) {
> pr_err("Immediate data (length %d + %d) exceeds request size %d\n",
> imm_data_offset, len, srp_max_req_size);
> return -EINVAL;
Do the srp tests from https://github.com/linux-blktests/blktests/ still
pass with this patch applied?
Thanks,
Bart.
next prev parent reply other threads:[~2026-05-04 8:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 8:00 [PATCH] RDMA/srpt: fix integer overflow in immediate data length check Sara Venkatesh
2026-05-04 8:17 ` Bart Van Assche [this message]
2026-05-05 0:11 ` Sara Venkatesh
2026-05-05 8:19 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbc57009-f563-4858-91f1-a63efe786d01@acm.org \
--to=bvanassche@acm.org \
--cc=carlos.bilbao@kernel.org \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sarajvenkatesh@gmail.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox