Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: Bob Pearson <rpearsonhpe@gmail.com>
To: "lizhijian@fujitsu.com" <lizhijian@fujitsu.com>,
	Yanjun Zhu <yanjun.zhu@linux.dev>, Jason Gunthorpe <jgg@ziepe.ca>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH for-next v2] RDMA/rxe: Remove unused mask parameter
Date: Fri, 15 Jul 2022 12:21:50 -0500	[thread overview]
Message-ID: <dc5168c3-0d3c-970a-652d-6bd1447a17a5@gmail.com> (raw)
In-Reply-To: <20220715035340.1900168-1-lizhijian@fujitsu.com>

On 7/14/22 22:46, lizhijian@fujitsu.com wrote:
> This parameter had beed deprecated since below commit:
> 1a7085b34291 ("RDMA/rxe: Skip adjusting remote addr for write in retry operation")
> 
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
> ---
> Feel free to add above commit to fixes tag if needed.
> V2: add commit log.
> ---
>  drivers/infiniband/sw/rxe/rxe_req.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/infiniband/sw/rxe/rxe_req.c b/drivers/infiniband/sw/rxe/rxe_req.c
> index 69fc35485e60..35a249727435 100644
> --- a/drivers/infiniband/sw/rxe/rxe_req.c
> +++ b/drivers/infiniband/sw/rxe/rxe_req.c
> @@ -15,8 +15,7 @@ static int next_opcode(struct rxe_qp *qp, struct rxe_send_wqe *wqe,
>  		       u32 opcode);
>  
>  static inline void retry_first_write_send(struct rxe_qp *qp,
> -					  struct rxe_send_wqe *wqe,
> -					  unsigned int mask, int npsn)
> +					  struct rxe_send_wqe *wqe, int npsn)
>  {
>  	int i;
>  
> @@ -83,7 +82,7 @@ static void req_retry(struct rxe_qp *qp)
>  			if (mask & WR_WRITE_OR_SEND_MASK) {
>  				npsn = (qp->comp.psn - wqe->first_psn) &
>  					BTH_PSN_MASK;
> -				retry_first_write_send(qp, wqe, mask, npsn);
> +				retry_first_write_send(qp, wqe, npsn);
>  			}
>  
>  			if (mask & WR_READ_MASK) {

Reviewed-by: Bob Pearson <rpearsonhpe@gmail.com>

  reply	other threads:[~2022-07-15 17:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-15  3:46 [PATCH for-next v2] RDMA/rxe: Remove unused mask parameter lizhijian
2022-07-15 17:21 ` Bob Pearson [this message]
2022-07-18 11:52 ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc5168c3-0d3c-970a-652d-6bd1447a17a5@gmail.com \
    --to=rpearsonhpe@gmail.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-rdma@vger.kernel.org \
    --cc=lizhijian@fujitsu.com \
    --cc=yanjun.zhu@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox