From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E12562036E3; Thu, 6 Mar 2025 10:40:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.193 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741257613; cv=none; b=qROeI+n0SaezLc+H4RJ0Jo8N05i0IGQRSmHKw8uXIBxLZhJJVPT8P1aovD9GAmnaXgSWQVvXfzAu/Haw0IXb+dgVZCG+bT2iQLg9WWhYrKMlSnU8ObBId/fokuKvsRNpKuw3FlhKFIBclqKvQlCAqOXE3akCQd+6Pq9Nc/eWx6Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741257613; c=relaxed/simple; bh=3JBdFCiYrIC+RNOrHoqq7a8iUKdN0ZQ9gy4GJ7lxkLk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sWbEXu4tBVvZV9ZefJtmxIgSu9Kme2NaI9kjYR2wrKTX4M8krl1D0XwjTjLhswWRrcqmaHVhf8f2gwUBdzVFDxaeTt1GYl6qrBygV4XIndz9aRlAL+TPpzG33c1eZyLa9Ul0mZ8UJ7vfkAFP3lgZCKLEF9GmSnlXWP2Xj5TLgSE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=clip-os.org; spf=pass smtp.mailfrom=clip-os.org; dkim=pass (2048-bit key) header.d=clip-os.org header.i=@clip-os.org header.b=lOUD7UmF; arc=none smtp.client-ip=217.70.183.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=clip-os.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=clip-os.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=clip-os.org header.i=@clip-os.org header.b="lOUD7UmF" Received: by mail.gandi.net (Postfix) with ESMTPSA id 8AD7944298; Thu, 6 Mar 2025 10:40:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=clip-os.org; s=gm1; t=1741257607; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6wbUiKVMo+ilWlUo2t+dlVeBduqmoy102Za6yfVmUbI=; b=lOUD7UmFH4D9eg9UusCKx4HU1ChMUUVggiAkzFpMX8L4ZgWA87DKsA2dHER5Q2yZZ9gMHg y2Pu6kRs7grKmmqZHpCHdVKU5DMQMlXqY5Lv1yxr4y9+N32bH5ULpu75Xx+c+tAiKk0Job m/ImXuBLgnK3iw4KFI7b2jD8CC+JojaEzmNO/54eiJPeCmqHSQswd2kgbNQDaWNhF+hFDK WdQjtHMWWPHosx5Q10ChVDX00jxZbJzCZ2IflhfEDSlD9N+D55o0THw/IbYq9ijVZeUAgr JDpUYIsMlqiwfy4zmLub5df+eACBJWPBoJ4/8OFs3r/HvcTeWG1WzzrGGYfMBw== Message-ID: Date: Thu, 6 Mar 2025 11:40:03 +0100 Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/6] sysctl/coda: Fixes timeout bounds To: Joel Granados , Jan Harkes Cc: linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-nfs@vger.kernel.org, Nicolas Bouchinet , Joel Granados , Clemens Ladisch , Arnd Bergmann , Greg Kroah-Hartman , Jason Gunthorpe , Leon Romanovsky , "James E.J. Bottomley" , "Martin K. Petersen" , Chuck Lever , Jeff Layton , Neil Brown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Trond Myklebust , Anna Schumaker , Bart Van Assche , Zhu Yanjun , Al Viro , Christian Brauner References: <20250224095826.16458-1-nicolas.bouchinet@clip-os.org> <20250224095826.16458-4-nicolas.bouchinet@clip-os.org> <20250303143937.etzv7idjbenugsgw@cs.cmu.edu> Content-Language: en-US From: Nicolas Bouchinet In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddutdejheefucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddvjeenucfhrhhomheppfhitgholhgrshcuuehouhgthhhinhgvthcuoehnihgtohhlrghsrdgsohhutghhihhnvghtsegtlhhiphdqohhsrdhorhhgqeenucggtffrrghtthgvrhhnpedtgfegjeejhfelueffteeukeethfeludekgeevgfetueeguefhkeduffelhefgteenucfkphepledtrdeifedrvdegiedrudekjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeltddrieefrddvgeeirddukeejpdhhvghloheplgduledvrdduieekrdeffedrieehngdpmhgrihhlfhhrohhmpehnihgtohhlrghsrdgsohhutghhihhnvghtsegtlhhiphdqohhsrdhorhhgpdhnsggprhgtphhtthhopedvjedprhgtphhtthhopehjohgvlhdrghhrrghnrgguohhssehkvghrnhgvlhdrohhrghdprhgtphhtthhopehjrghhrghrkhgvshestghsrdgtmhhurdgvughupdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtoheplhhinhhugidqrhgumhgrsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrt ghpthhtoheplhhinhhugidqshgtshhisehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtoheplhhinhhugidqnhhfshesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopehnihgtohhlrghsrdgsohhutghhihhnvghtsehsshhirdhgohhuvhdrfhhrpdhrtghpthhtohepjhdrghhrrghnrgguohhssehsrghmshhunhhgrdgtohhm X-GND-Sasl: nicolas.bouchinet@clip-os.org Hi Jan and Joel, Thanks for your review, I'll update coda_timeout type to an unsigned int and push back the patchset without patches that has moved in their subsystems. Best regards, Nicolas On 3/5/25 15:47, Joel Granados wrote: > On Mon, Mar 03, 2025 at 09:39:37AM -0500, Jan Harkes wrote: >> On Mon, Mar 03, 2025 at 09:16:10AM -0500, Joel Granados wrote: >>> On Mon, Feb 24, 2025 at 10:58:18AM +0100, nicolas.bouchinet@clip-os.org wrote: >>>> From: Nicolas Bouchinet >>>> >>>> Bound coda timeout sysctl writings between SYSCTL_ZERO >>>> and SYSCTL_INT_MAX. >>>> >>>> The proc_handler has thus been updated to proc_dointvec_minmax. >>>> >>>> Signed-off-by: Nicolas Bouchinet >>>> --- >>>> fs/coda/sysctl.c | 4 +++- >>>> 1 file changed, 3 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/fs/coda/sysctl.c b/fs/coda/sysctl.c >>>> index 0df46f09b6cc5..d6f8206c51575 100644 >>>> --- a/fs/coda/sysctl.c >>>> +++ b/fs/coda/sysctl.c >>>> @@ -20,7 +20,9 @@ static const struct ctl_table coda_table[] = { >>>> .data = &coda_timeout, >>> I noticed that coda_timeout is an unsigned long. With that in mind I >>> would change it to unsigned int. It seems to be a value that can be >>> ranged within [0,INT_MAX] >> That seems fine by me. >> >> It is a timeout in seconds and it is typically set to some value well >> under a minute. >> > Thx for the confirmation. I'll let nicolas take care of the change > Best >