From: Don Hiatt <don.hiatt-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: "Hefty,
Sean" <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
linux-rdma <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH rdma-next 2/3] IB/CM: Create appropriate path records when handling CM request
Date: Wed, 7 Jun 2017 10:23:54 -0700 [thread overview]
Message-ID: <e1d035ef-f8f8-6ea1-8277-646e01c55bd3@intel.com> (raw)
In-Reply-To: <1828884A29C6694DAF28B7E6B8A82373AB140319-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
On 6/5/2017 1:40 PM, Hefty, Sean wrote:
>> + /*
>> + * If the gid in the request is an OPA GID,
>> + * create an OPA PR
>> + */
>> + if (ib_is_opa_gid(&req_msg->primary_local_gid) &&
>> + rdma_cap_opa_ah(work->port->cm_dev->ib_device,
>> + work->port->port_num))
>> + work->path[0].rec_type = SA_PATH_REC_TYPE_OPA;
>> + else
>> + work->path[0].rec_type = SA_PATH_REC_TYPE_IB;
> Maybe create a function for this logic (repeated 3 times)? E.g. cm_path_rec_type(device, port, gid)
>
Good point. Will do in next revision.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-06-07 17:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-05 18:20 [PATCH rdma-next 0/3] Enhance IB CM to support OPA extended LIDs Don Hiatt
[not found] ` <1496686803-51338-1-git-send-email-don.hiatt-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-06-05 18:20 ` [PATCH rdma-next 1/3] IB/CM: Add OPA Path record support to CM Don Hiatt
[not found] ` <1496686803-51338-2-git-send-email-don.hiatt-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-06-05 19:33 ` Jason Gunthorpe
[not found] ` <20170605193357.GA21236-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-06-07 17:26 ` Don Hiatt
2017-06-05 18:20 ` [PATCH rdma-next 2/3] IB/CM: Create appropriate path records when handling CM request Don Hiatt
[not found] ` <1496686803-51338-3-git-send-email-don.hiatt-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-06-05 20:40 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A82373AB140319-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2017-06-07 17:23 ` Don Hiatt [this message]
2017-06-05 18:20 ` [PATCH rdma-next 3/3] IB/CM: Set appropriate slid and dlid " Don Hiatt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1d035ef-f8f8-6ea1-8277-646e01c55bd3@intel.com \
--to=don.hiatt-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox