From: Tariq Toukan <ttoukan.linux@gmail.com>
To: Chen Ni <nichen@iscas.ac.cn>,
saeedm@nvidia.com, leon@kernel.org, tariqt@nvidia.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com
Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] net/mlx5: Use to_delayed_work()
Date: Thu, 15 May 2025 09:23:01 +0300 [thread overview]
Message-ID: <e2c6c100-c1bb-45f1-a171-2effdd69e409@gmail.com> (raw)
In-Reply-To: <20250514072419.2707578-1-nichen@iscas.ac.cn>
On 14/05/2025 10:24, Chen Ni wrote:
> Use to_delayed_work() instead of open-coding it.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
> Changelog:
>
> v1 -> v2:
>
> 1. Specify the target tree.
> ---
> drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
> index e53dbdc0a7a1..b1aeea7c4a91 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
> @@ -927,8 +927,7 @@ static void mlx5_cmd_comp_handler(struct mlx5_core_dev *dev, u64 vec, bool force
>
> static void cb_timeout_handler(struct work_struct *work)
> {
> - struct delayed_work *dwork = container_of(work, struct delayed_work,
> - work);
> + struct delayed_work *dwork = to_delayed_work(work);
> struct mlx5_cmd_work_ent *ent = container_of(dwork,
> struct mlx5_cmd_work_ent,
> cb_timeout_work);
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Thanks for your patch.
next prev parent reply other threads:[~2025-05-15 6:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-14 7:24 [PATCH net-next v2] net/mlx5: Use to_delayed_work() Chen Ni
2025-05-14 7:37 ` Mark Bloch
2025-05-15 6:23 ` Tariq Toukan [this message]
2025-05-15 15:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2c6c100-c1bb-45f1-a171-2effdd69e409@gmail.com \
--to=ttoukan.linux@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nichen@iscas.ac.cn \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox