From: Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>
To: Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] IB/srp: reduce number of interrupts
Date: Sun, 28 Feb 2010 12:02:38 +0100 [thread overview]
Message-ID: <e2e108261002280302pc0a63b0l9d4dc16ec7b901d@mail.gmail.com> (raw)
In-Reply-To: <adamxyyxm9s.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org>
On Thu, Feb 25, 2010 at 12:10 AM, Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org> wrote:
>
> thanks, applied, and I added the following cleanup on top too.
> The old mess wasn't your fault of course but I think this makes things a
> bit safer, assuming I didn't mess it up:
>
> IB/srp: Clean up error path in srp_create_target_ib()
>
> Instead of repeating the error unwinding steps in each place an error
> can be detected, use the common idiom of gotos into an error flow.
>
> Signed-off-by: Roland Dreier <rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
Thanks for applying the interrupt rate reduction patch, and thanks for
cleaning up the error path of srp_create_target_ib(). I'm afraid that
it's too late to add an acked-by to that patch ? Anyway:
Acked-by: Bart Van Assche <bart.vanassche-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2010-02-28 11:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-02 19:23 [PATCH] IB/srp: reduce number of interrupts Bart Van Assche
[not found] ` <201002022023.54554.bart.vanassche-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-02-24 23:10 ` Roland Dreier
[not found] ` <adamxyyxm9s.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org>
2010-02-28 11:02 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2e108261002280302pc0a63b0l9d4dc16ec7b901d@mail.gmail.com \
--to=bvanassche-hinycgiudog@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).