Re: [PATCH for-next 0/4] Introduce Completion Counters

[Doug Ledford <doug.ledford@hpe.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2973 bytes --]

On 4/7/26 6:54 AM, Michael Margolin wrote:
> Add core infrastructure for Completion Counters, a light-weight
> alternative to polling CQ for tracking operation completions. The
> related rdma-core interface proposal is linked in [1].
> 
> Define the UVERBS_OBJECT_COMP_CNTR ioctl object with create, destroy,
> set, inc and read methods for both success and error counters. Add a
> QP attach method on the QP object to associate a completion counter
> with a queue pair.
> 
> Completion Counters can be backed by user-provided VA or dmabuf or by
> internal device/driver memory. Common command infrastructure allows any
> of the implementations to support the various device capabilities.
> 
> Add EFA Completion Counters support as first implementer.
> 
> [1] https://github.com/linux-rdma/rdma-core/pull/1701
> 
> Michael Margolin (4):
>    RDMA/core: Add Completion Counters support
>    RDMA/core: Add Completion Counters to resource tracking
>    RDMA/efa: Update device interface
>    RDMA/efa: Add Completion Counters support
> 
>   drivers/infiniband/core/Makefile              |   1 +
>   drivers/infiniband/core/device.c              |  10 +
>   drivers/infiniband/core/nldev.c               |   1 +
>   drivers/infiniband/core/rdma_core.h           |   1 +
>   drivers/infiniband/core/restrack.c            |   2 +
>   drivers/infiniband/core/uverbs_cmd.c          |   1 +
>   .../core/uverbs_std_types_comp_cntr.c         | 379 ++++++++++++++++++
>   drivers/infiniband/core/uverbs_std_types_qp.c |  45 ++-
>   drivers/infiniband/core/uverbs_uapi.c         |   1 +
>   drivers/infiniband/hw/efa/efa.h               |  15 +
>   .../infiniband/hw/efa/efa_admin_cmds_defs.h   | 185 ++++++++-
>   drivers/infiniband/hw/efa/efa_com_cmd.c       | 106 +++++
>   drivers/infiniband/hw/efa/efa_com_cmd.h       |  36 ++
>   drivers/infiniband/hw/efa/efa_io_defs.h       |  62 ++-
>   drivers/infiniband/hw/efa/efa_main.c          |   8 +
>   drivers/infiniband/hw/efa/efa_verbs.c         | 177 ++++++++
>   include/rdma/ib_verbs.h                       |  27 ++
>   include/rdma/restrack.h                       |   4 +
>   include/uapi/rdma/efa-abi.h                   |   1 +
>   include/uapi/rdma/ib_user_ioctl_cmds.h        |  65 +++
>   include/uapi/rdma/ib_user_ioctl_verbs.h       |   9 +
>   include/uapi/rdma/ib_user_verbs.h             |   2 +-
>   22 files changed, 1131 insertions(+), 7 deletions(-)
>   create mode 100644 drivers/infiniband/core/uverbs_std_types_comp_cntr.c
> 

Our hardware does have completion counters.  I haven't dug into them in 
detail in the past, but if this isn't already merged, I can dig in at 
least well enough to make sure the API will be usable for us too. 
Probably next week as I'm at the UEC Face to Face this week.

-- 
Doug Ledford <doug.ledford@hpe.com>
     GPG KeyID: B826A3330E572FDD
     Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]